mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Alex Nixon" <alex.nixon@citrix.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Jeremy Fitzhardinge" <Jeremy.Fitzhardinge@citrix.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: Change the default value of nr_irqs from 32 to NR_IRQs
Date: Tue, 19 Aug 2008 10:44:43 -0700	[thread overview]
Message-ID: <86802c440808191044h74871ba1u62330dae18599436@mail.gmail.com> (raw)
In-Reply-To: <48AAFAE4.7070409@citrix.com>

On Tue, Aug 19, 2008 at 9:55 AM, Alex Nixon <alex.nixon@citrix.com> wrote:
> From: Alex Nixon <alex.nixon@citrix.com>
> Date: Tue, 19 Aug 2008 17:49:37 +0100
> Subject: [PATCH] X86:  Change the default value of nr_irqs from 32 to NR_IRQs
>
> If the number of discovered IRQs is suspiciously low, this patch causes the number reported to default to NR_IRQS, rather than 32.  NR_IRQS has already been defined to be a sensible value for the current system (in particular, at least 224 when paravirtualisation is involved).
>
> Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
> ---
>  arch/x86/kernel/io_apic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
> index 30ff794..11bffa1 100644
> --- a/arch/x86/kernel/io_apic.c
> +++ b/arch/x86/kernel/io_apic.c
> @@ -3632,7 +3632,7 @@ int __init probe_nr_irqs(void)
>
>        /* something wrong ? */
>        if (nr < 32)
> -               nr = 32;
> +               nr = NR_IRQS;
>
>        return nr;
>  }
> --
if only one ioapic, nr will be 24<<1, you will get 48. Does pv has io apic ?

YH

  reply	other threads:[~2008-08-19 17:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19 16:55 Alex Nixon
2008-08-19 17:44 ` Yinghai Lu [this message]
     [not found]   ` <0E902970173AF84089673FA54B7FE78A2CA11D@lonpexch01.citrite.net>
2008-08-19 18:24     ` Yinghai Lu
2008-08-19 18:32       ` Alex Nixon
2008-08-19 19:00         ` Yinghai Lu
2008-08-19 19:50           ` Alex Nixon
2008-08-19 20:52             ` Yinghai Lu
2008-08-19 23:19               ` Alex Nixon
2008-08-20 23:23                 ` Alex Nixon
2008-08-20 23:47                   ` Yinghai Lu
2008-08-21 23:21                     ` Jeremy Fitzhardinge
2008-08-20 23:23     ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440808191044h74871ba1u62330dae18599436@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=Jeremy.Fitzhardinge@citrix.com \
    --cc=alex.nixon@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®