From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Suresh Siddha" <suresh.b.siddha@intel.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
ebiederm@xmission.com, x86@kernel.org
Subject: Re: [patch] fix intr-remap with dyn_array/nr_irqs changes
Date: Tue, 19 Aug 2008 12:40:21 -0700 [thread overview]
Message-ID: <86802c440808191240t66ee67c1ub173c462025b6929@mail.gmail.com> (raw)
In-Reply-To: <20080819185441.GC1152@linux-os.sc.intel.com>
On Tue, Aug 19, 2008 at 11:54 AM, Suresh Siddha
<suresh.b.siddha@intel.com> wrote:
> I didn't find time to closely review the dyn_array/nr_irqs changes. But
> the appended patch is needed to fix the broken intr-remapping support on
> x86/tip
>
> And also, I don't see any locks used in to_irq_desc_with_new(). How are
> we handling the concurrent usage scenarios. And also, this code can use
> some cleanups (like the names, to_irq_desc_with_new()?) etc.
>
> thanks,
> suresh
> ---
>
> In irq_2_iommu_with_new() and set_irte_irq(), irq_desc or
> irq_2_iommu pointers may not be allocated. So use the routines which
> will allocate them if they are not already allocated.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
i'm trying to rebase sparseirq to tip/x86/core.
will address your concern about lock after that.
Thanks
YH
prev parent reply other threads:[~2008-08-19 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 18:54 Suresh Siddha
2008-08-19 19:40 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440808191240t66ee67c1ub173c462025b6929@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®