From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
tglx@linutronix.de, hpa@zytor.com, jbarnes@virtuousgeek.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: split e820 reserved entries record to late v4 - fix v7
Date: Thu, 4 Sep 2008 12:22:17 -0700 [thread overview]
Message-ID: <86802c440809041222q244e1adaj16b80f1590053bcf@mail.gmail.com> (raw)
In-Reply-To: <20080904121627.bc182da7.akpm@linux-foundation.org>
On Thu, Sep 4, 2008 at 12:16 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 4 Sep 2008 21:04:57 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
>> + printk(KERN_DEBUG " __reserve_region_with_split: (%s) [%llx, %llx], res: (%s) [%llx, %llx]\n",
>> + conflict->name, conflict->start, conflict->end,
>> + name, start, end);
>
> start and end have type resource_size_t. Such types CANNOT be printed
> unless cast to a known type.
>
> Because there is a %s following an incorrect %lld, the above code will
> crash the machine.
should just remove those lines.
YH
next prev parent reply other threads:[~2008-09-04 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 7:31 Yinghai Lu
2008-09-04 19:04 ` Ingo Molnar
2008-09-04 19:16 ` Andrew Morton
2008-09-04 19:22 ` Yinghai Lu [this message]
2008-10-13 20:32 ` Tony Luck
2008-10-13 21:14 ` H. Peter Anvin
2008-10-13 21:17 ` Luck, Tony
2008-10-13 21:46 ` Linus Torvalds
2008-10-13 21:54 ` H. Peter Anvin
2008-10-13 22:40 ` Yinghai Lu
2008-10-13 22:48 ` H. Peter Anvin
2008-10-14 5:29 ` Yinghai Lu
2008-09-05 8:52 ` Yinghai Lu
2008-09-05 11:45 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440809041222q244e1adaj16b80f1590053bcf@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®