From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757391AbYIDUg4 (ORCPT ); Thu, 4 Sep 2008 16:36:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759775AbYIDUcT (ORCPT ); Thu, 4 Sep 2008 16:32:19 -0400 Received: from rv-out-0506.google.com ([209.85.198.238]:27848 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759709AbYIDUcR (ORCPT ); Thu, 4 Sep 2008 16:32:17 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=F54mtdFfXPWXIlmyDmxlU9gyUrZuc6W27J69v4xO/AQ9iR2O76m2mIe2rQsvqBAAb4 oru3A2Gua3GEK24/kJ5JxRGDjSBAxn6Hx68Z0ArofSHNhAEo73J/p9OMyc3haK0BvE3f lX0X+gGujaJueRjnUJnXxzvAWhW85VJ5hmLVA= Message-ID: <86802c440809041332w197c2b88w95eda369dbb7761e@mail.gmail.com> Date: Thu, 4 Sep 2008 13:32:16 -0700 From: "Yinghai Lu" To: "Ingo Molnar" Subject: Re: [PATCH] x86: order functions in cpu/common.c and cpu/common_64.c Cc: "Thomas Gleixner" , "H. Peter Anvin" , "Andrew Morton" , linux-kernel@vger.kernel.org In-Reply-To: <86802c440809041307i24cce782u4937d6fd2311c6f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1220331936-15100-1-git-send-email-yhlu.kernel@gmail.com> <20080904191205.GC24990@elte.hu> <20080904193733.GA25136@elte.hu> <20080904194127.GA2542@elte.hu> <20080904200421.GA24295@elte.hu> <86802c440809041307i24cce782u4937d6fd2311c6f@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 4, 2008 at 1:07 PM, Yinghai Lu wrote: > On Thu, Sep 4, 2008 at 1:04 PM, Ingo Molnar wrote: >> >> * Ingo Molnar wrote: >> >>> > i've pushed out the broken tree into tip/tmp.master.broken (havent >>> > updated tip/master with the breakage). I've removed the broken >>> > printk in kernel/resource.c that Andrew found, see commit >>> > 06e44f6af324 - so that's not the cause. >>> >>> i've double checked that 06e44f6af324 is applied. I'll bisect this. >> >> bisection came up with: >> >> # good: [8bfd9710] Merge branch 'x86/xsave' >> # bad: [06e44f6a] IO resources: fix/remove printk >> # good: [282a5f84] Merge branch 'irq/sparseirq' >> # bad: [a0854a46] x86: make 32bit support show_msr like 64 bit >> # good: [5031088d] x86: delay early cpu initialization until cpuid is >> # good: [9d31d35b] x86: order functions in cpu/common.c and cpu/commo >> # bad: [10a434fc] x86: remove cpu_vendor_dev >> >> | 10a434fcb23a57c385177a0086955fae01003f64 is first bad commit >> | commit 10a434fcb23a57c385177a0086955fae01003f64 >> | Author: Yinghai Lu >> | Date: Thu Sep 4 21:09:45 2008 +0200 >> | >> | x86: remove cpu_vendor_dev >> >> and the thing is, 10a434fc is way too big: >> >> | 15 files changed, 106 insertions(+), 106 deletions(-) >> >> and it's not obvious at first (neither at second) sight what the problem >> is. You really need to start doing much smaller patches for such >> critical/hard-to-debug code areas. >> > could be alignment again... ffffffff80d86c20 d __cpu_dev_amd_cpu_dev ffffffff80d86c20 A __x86_cpu_dev_start ffffffff80d86c28 d __dyn_array_ptr_irq_2_pin_head ffffffff80d86c28 D __dyn_array_start ffffffff80d86c30 d __dyn_array_ptr_irq_cfgx ffffffff80d86c38 d __dyn_array_ptr_sparse_irqs ffffffff80d86c40 D __dyn_array_end ffffffff80d86c40 d __initcall_selinux_init ffffffff80d86c40 D __per_cpu_dyn_array_end ffffffff80d86c40 D __per_cpu_dyn_array_start ffffffff80d86c40 D __security_initcall_start ffffffff80d86c48 R __parainstructions ffffffff80d86c48 D __security_initcall_end ffffffff80d86c48 A __x86_cpu_dev_end don't know how could the linker squash others tables into cpu_dev pointer array.. YH