mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Dean Nelson" <dcn@sgi.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ
Date: Fri, 5 Sep 2008 10:03:37 -0700	[thread overview]
Message-ID: <86802c440809051003o6829e7d5i2dd683f5e0dd0ae4@mail.gmail.com> (raw)
In-Reply-To: <20080905144648.GA10292@elte.hu>

On Fri, Sep 5, 2008 at 7:46 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Dean Nelson <dcn@sgi.com> wrote:
>
>> An error return from create_irq_nr() is 0, but an error return from
>> create_irq() is -1.
>>
>> Signed-off-by: Dean Nelson <dcn@sgi.com>
>
> applied to tip/irq/sparseirq - thanks Dean!
>
need to change irq to int too

diff --git a/drivers/pci/htirq.c b/drivers/pci/htirq.c
index 7c5aef1..468115d 100644
--- a/drivers/pci/htirq.c
+++ b/drivers/pci/htirq.c
@@ -109,7 +109,7 @@ int __ht_create_irq(struct pci_dev *dev, int idx,
ht_irq_update_t *update)
        u32 data;
        int max_irq;
        int pos;
-       unsigned int irq;
+       int irq;
        unsigned int irq_want;

        pos = pci_find_ht_capability(dev, HT_CAPTYPE_IRQ);

  reply	other threads:[~2008-09-05 17:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-05 14:07 Dean Nelson
2008-09-05 14:46 ` Ingo Molnar
2008-09-05 17:03   ` Yinghai Lu [this message]
2008-09-05 17:07     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440809051003o6829e7d5i2dd683f5e0dd0ae4@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=dcn@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®