From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Cyrill Gorcunov" <gorcunov@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: do_boot_cpu - check for ESR apic register presence before touching
Date: Mon, 15 Sep 2008 09:12:37 -0700 [thread overview]
Message-ID: <86802c440809150912r222b399eg552208646decd9d4@mail.gmail.com> (raw)
In-Reply-To: <20080915150518.GA23798@lenovo>
On Mon, Sep 15, 2008 at 8:05 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> We should check first if there is ESR register before read/write it.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>
> Please review and test if possible. Thanks.
>
> Index: linux-2.6.git/arch/x86/kernel/smpboot.c
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/smpboot.c 2008-09-14 21:49:36.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/smpboot.c 2008-09-15 18:30:37.000000000 +0400
> @@ -893,8 +893,10 @@ do_rest:
> /*
> * Be paranoid about clearing APIC errors.
> */
> - apic_write(APIC_ESR, 0);
> - apic_read(APIC_ESR);
> + if (APIC_INTEGRATED(apic_version[phys_apicid])) {
> + apic_write(APIC_ESR, 0);
> + apic_read(APIC_ESR);
> + }
> }
>
> /*
>
maybe unrelated. Do we need to keep apic_version array?
YH
next prev parent reply other threads:[~2008-09-15 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 15:05 Cyrill Gorcunov
2008-09-15 16:12 ` Yinghai Lu [this message]
2008-09-15 16:22 ` Cyrill Gorcunov
2008-09-15 16:25 ` Yinghai Lu
2008-09-15 16:30 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440809150912r222b399eg552208646decd9d4@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®