From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754135AbYIQIlS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754135AbYIQIlS (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Sep 2008 04:41:18 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751144AbYIQIlH
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 17 Sep 2008 04:41:07 -0400
Received: from rv-out-0506.google.com ([209.85.198.231]:17097 "EHLO
	rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750881AbYIQIlE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Sep 2008 04:41:04 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=I6kQBnYnO08mmthj0qe4Jr5XSRbY/iJfj/NVzAF0ciBhP5eRKVJIYAYQdgFLqMRjAi
         DM4vR3gAlQQIhz84wWussJZiZoMAtf0nwQHV62u7CUwU0TbBijhcPDI09iwKqR5Sk237
         lZbBgIrMaTHKYeHXbssxSq8wEtIbddhbHjljc=
Message-ID: <86802c440809170141s5c206ec9ub1ea077ed923ec20@mail.gmail.com>
Date: Wed, 17 Sep 2008 01:41:03 -0700
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Subject: Re: [PATCH 3/6] pci: using printk(KERN_PCI v3
Cc: "Thomas Gleixner" <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
       "Andrew Morton" <akpm@linux-foundation.org>,
       linux-kernel@vger.kernel.org
In-Reply-To: <20080917083506.GA24035@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1221640067-24389-1-git-send-email-yhlu.kernel@gmail.com>
	 <1221640067-24389-4-git-send-email-yhlu.kernel@gmail.com>
	 <20080917083506.GA24035@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 17, 2008 at 1:35 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
>> -                     printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
>> +                     printk(KERN_DEBUG KERN_PCI
>> +                              "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
>
> i think we should aim to make the common usage of this facility as easy
> and short as possible. That means that i think the right line is:
>
> +                       printk(KERN_PCI
> +                                "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
>
> as that is the shortest form. KERN_PCI should imply whatever
> common-sense default. It should still make sense to specify KERN_FOO
> KERN_PCI, to override that default.

vprintk will add default before that like
like print(KERN_INFO KERN_PCI ....)

YH