Re: [PATCH] x86: mtrr_cleanup hole size should be less than half of chunk_size v2

["Yinghai Lu" <yinghai@kernel.org>]

On Sat, Sep 27, 2008 at 8:26 PM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> v2: should check with half of range0 size instead of chunk_size
>
> So don't have silly big hole.
>
> in hpa's case we could auto detect instead of adding mtrr_chunk_size in command line
>
> Ingo, please consider to squash this one to previous one
> |  commit 2313c2793d290a8cc37c428f8622c53f3fe1d6dc
> |  Author: Yinghai Lu <yhlu.kernel@gmail.com>
> |  Date:   Sat Sep 27 00:30:08 2008 -0700
> |
> |      x86: mtrr_cleanup optimization, v2
>
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>

Dylan,

please try tip/master after Ingo put this patch into it...

from
reg00: base=0x00000000 (   0MB), size=4096MB: write-back, count=1
reg01: base=0x100000000 (4096MB), size= 512MB: write-back, count=1
reg02: base=0x120000000 (4608MB), size= 256MB: write-back, count=1
reg03: base=0xd0000000 (3328MB), size= 256MB: uncachable, count=1
reg04: base=0xe0000000 (3584MB), size= 512MB: uncachable, count=1
reg05: base=0xc7e00000 (3198MB), size=   2MB: uncachable, count=1
reg06: base=0xc8000000 (3200MB), size= 128MB: uncachable, count=1

you should get
Found optimal setting for mtrr clean up
gran_size: 1M   chunk_size: 256M        num_reg: 7      lose RAM: 0M
range0: 0000000000000000 - 00000000d0000000
Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
Setting variable MTRR 2, base: 3072MB, range: 256MB, type WB
hole: 00000000c7e00000 - 00000000d0000000
Setting variable MTRR 3, base: 3198MB, range: 2MB, type UC
Setting variable MTRR 4, base: 3200MB, range: 128MB, type UC
rangeX: 0000000100000000 - 0000000130000000
Setting variable MTRR 5, base: 4096MB, range: 512MB, type WB
Setting variable MTRR 6, base: 4608MB, range: 256MB, type WB


with mtrr_spare_reg_nr=2 you should get
Found optimal setting for mtrr clean up
gran_size: 1M   chunk_size: 4M        num_reg: 6      lose RAM: 0M
range0: 0000000000000000 - 00000000c8000000
Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB
hole: 00000000c7e00000 - 00000000c8000000
Setting variable MTRR 3, base: 3198MB, range: 2MB, type UC
rangeX: 0000000100000000 - 0000000130000000
Setting variable MTRR 4, base: 4096MB, range: 512MB, type WB
Setting variable MTRR 5, base: 4608MB, range: 256MB, type WB