From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbYI3Uhi (ORCPT ); Tue, 30 Sep 2008 16:37:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751983AbYI3Uha (ORCPT ); Tue, 30 Sep 2008 16:37:30 -0400 Received: from rv-out-0506.google.com ([209.85.198.229]:25433 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbYI3Uh3 (ORCPT ); Tue, 30 Sep 2008 16:37:29 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=Nn8ATh3W05a59BuL5NARARV8Bwyvdv7F58wnrtlSm577x7ou+5HlO2AB+R1hK3hKLX +qO4LDamphUGzIGP58OQ6b5aHU0iuY2XAfV+XqGGqgzJKwJZSmlXlx8adDNp9J/DrAjN 0Q5Ylp8IK2el3Dv2cL10pRuRW9ifxpz62TncE= Message-ID: <86802c440809301337i1bbf6e9ckb8de8a1ef08955d3@mail.gmail.com> Date: Tue, 30 Sep 2008 13:37:28 -0700 From: "Yinghai Lu" To: "Alexander van Heukelum" Subject: Re: [PATCH] fix: x86: remove cpu_vendor_dev Cc: "Ingo Molnar" , LKML In-Reply-To: <20080930193736.GA4453@mailshack.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1222792897-5691-1-git-send-email-heukelum@fastmail.fm> <20080930193736.GA4453@mailshack.com> X-Google-Sender-Auth: 36e0b05ece4ed49a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 30, 2008 at 12:37 PM, Alexander van Heukelum wrote: > x86_64-kernels after commit 10a434fcb "x86: remove cpu_vendor_dev" > crashed on qemu-system-x86_64 due to a typo in vmlinux_64.lds.S. > > Signed-off-by: Alexander van Heukelum > > --- > > On Tue, Sep 30, 2008 at 06:41:33PM +0200, Alexander van Heukelum wrote: >> Moreover, a defconfig won't run :-/ (on qemu-system-x86_64). >> Bisection pointed to commit 10a434fcb "x86: remove cpu_vendor_dev". >> The kernel crashes early with a general protection fault in a call >> to strnlen. I have no idea what goes wrong, yet. > > It took quite some time, but I found the problem... I'll leave > the other one to you ;). > > Greetings, > Alexander > > arch/x86/kernel/vmlinux_64.lds.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/vmlinux_64.lds.S b/arch/x86/kernel/vmlinux_64.lds.S > index 201e81a..46e0544 100644 > --- a/arch/x86/kernel/vmlinux_64.lds.S > +++ b/arch/x86/kernel/vmlinux_64.lds.S > @@ -172,8 +172,8 @@ SECTIONS > .x86_cpu_dev.init : AT(ADDR(.x86_cpu_dev.init) - LOAD_OFFSET) { > *(.x86_cpu_dev.init) > } > - SECURITY_INIT > __x86_cpu_dev_end = .; > + SECURITY_INIT > > . = ALIGN(8); > .parainstructions : AT(ADDR(.parainstructions) - LOAD_OFFSET) { > that is merging problem, Ingo should fix that already... YH