mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yinghai@kernel.org>
To: "J.A. Magallón" <jamagallon@ono.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M
Date: Thu, 2 Oct 2008 15:46:20 -0700	[thread overview]
Message-ID: <86802c440810021546r6182a0c2id3566c1eb6ab7410@mail.gmail.com> (raw)
In-Reply-To: <86802c440810021539y6cdff33dh9df3e04eba85a9df@mail.gmail.com>

On Thu, Oct 2, 2008 at 3:39 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Thu, Oct 2, 2008 at 3:32 PM, J.A. Magallón <jamagallon@ono.com> wrote:
>> On Mon, 29 Sep 2008 18:54:12 -0700, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>>
>> Also, on a 64 bit box with 4Gb, it gives this:
>>
>> cicely:~# cat /proc/mtrr
>> reg00: base=0x00000000 (   0MB), size=4096MB: write-back, count=1
>> reg01: base=0x100000000 (4096MB), size=1024MB: write-back, count=1
>> reg02: base=0x140000000 (5120MB), size= 512MB: write-back, count=1
>> reg03: base=0x160000000 (5632MB), size= 256MB: write-back, count=1
>> reg04: base=0x80000000 (2048MB), size=2048MB: uncachable, count=1
>>
> boundary handling may have problem...

can you try

diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
index ef64128..70beb13 100644
--- a/arch/x86/kernel/cpu/mtrr/main.c
+++ b/arch/x86/kernel/cpu/mtrr/main.c
@@ -1044,7 +1044,7 @@ second_try:
                hole_sizek = range0_sizek - state->range_sizek - second_sizek;

                /* hole size should be less than half of range0 size */
-               if (hole_sizek > (range0_sizek >> 1) &&
+               if (hole_sizek >= (range0_sizek >> 1) &&
                    range0_sizek >= chunk_sizek) {
                        range0_sizek -= chunk_sizek;
                        second_sizek = 0;

YH

  reply	other threads:[~2008-10-02 22:46 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30  1:54 [PATCH 1/2] x86: mtrr_cleanup prepare to make gran_size to less 1M Yinghai Lu
2008-09-30  1:54 ` [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M Yinghai Lu
2008-10-02 22:03   ` J.A. Magallón
2008-10-02 22:33     ` Yinghai Lu
2008-10-02 22:52       ` Yinghai Lu
2008-10-02 23:00         ` J.A. Magallón
2008-10-02 23:20           ` Yinghai Lu
2008-10-02 22:58       ` J.A. Magallón
2008-10-02 23:55       ` D. Hugh Redelmeier
2008-10-03  1:27         ` Yinghai Lu
2008-10-02 22:32   ` J.A. Magallón
2008-10-02 22:39     ` Yinghai Lu
2008-10-02 22:46       ` Yinghai Lu [this message]
2008-10-03  7:38         ` Ingo Molnar
2008-10-02 23:20       ` J.A. Magallón
2008-10-02 23:45         ` Yinghai Lu
2008-10-03  7:37     ` Ingo Molnar
2008-10-03  7:38       ` H. Peter Anvin
2008-10-03  7:42         ` Ingo Molnar
2008-10-03  7:44           ` H. Peter Anvin
2008-10-03 14:57         ` D. Hugh Redelmeier
2008-10-03  7:40       ` H. Peter Anvin
2008-10-03  7:44         ` Ingo Molnar
2008-10-03  7:41       ` J.A. Magallón
2008-09-30  4:07 ` [PATCH 1/2] x86: mtrr_cleanup prepare to make gran_size to less 1M H. Peter Anvin
2008-09-30  7:45   ` Ingo Molnar
2008-09-30  8:11     ` Ingo Molnar
2008-09-30 16:06       ` Yinghai Lu
2008-09-30 18:50       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440810021546r6182a0c2id3566c1eb6ab7410@mail.gmail.com \
    --to=yinghai@kernel.org \
    --cc=jamagallon@ono.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®