From: "Yinghai Lu" <yinghai@kernel.org>
To: "huang ying" <huang.ying.caritas@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Huang Ying" <ying.huang@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] x86: make 64bit efi to use ioremap_cache for efi_ioremap
Date: Sat, 4 Oct 2008 10:44:00 -0700 [thread overview]
Message-ID: <86802c440810041044m5b950721s8700bb6cd2fe75d@mail.gmail.com> (raw)
In-Reply-To: <851fc09e0810040235g2ab97bdai612c0a2829f83f5c@mail.gmail.com>
On Sat, Oct 4, 2008 at 2:35 AM, huang ying <huang.ying.caritas@gmail.com> wrote:
> Hi, Yinghai,
>
> On Sat, Oct 4, 2008 at 2:23 PM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> [...]
>> --- linux-2.6.orig/arch/x86/kernel/efi.c
>> +++ linux-2.6/arch/x86/kernel/efi.c
>> @@ -475,10 +475,7 @@ void __init efi_enter_virtual_mode(void)
>> size = md->num_pages << EFI_PAGE_SHIFT;
>> end = md->phys_addr + size;
>>
>> - if (PFN_UP(end) <= max_low_pfn_mapped)
>> - va = __va(md->phys_addr);
>> - else
>> - va = efi_ioremap(md->phys_addr, size);
>> + va = efi_ioremap(md->phys_addr, size);
>
> Using __va and efi_ioremap() here is to make EFI support compatible
> with kexec. Because EFI provide only efi_enter_virtual_mode(), no
> efi_leave_virtual_mode(), we should make EFI runtime memory area
> mapped to same virtual memory area in original kernel and kexeced
> kernel, so that the EFI runtime services can be used in kexeced
> kernel.
so need to make efi range all under direct-mapping like E820-RAM?
if so we need to update
e820_end_of_low_ram_pfn to return correct max_low_pfn, and then
max_low_pfn_mapped...
YH
next prev parent reply other threads:[~2008-10-04 17:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 6:23 Yinghai Lu
2008-10-04 8:46 ` Ingo Molnar
2008-10-04 9:35 ` huang ying
2008-10-04 17:44 ` Yinghai Lu [this message]
2008-10-05 8:56 ` huang ying
2008-10-05 10:04 ` Ingo Molnar
2008-10-06 1:47 ` Huang Ying
2008-10-05 18:04 ` Yinghai Lu
2008-10-06 1:50 ` Huang Ying
2008-12-11 20:41 Jonathan Barkelew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440810041044m5b950721s8700bb6cd2fe75d@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=huang.ying.caritas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®