Re: [PATCH 1/3] x86: mtrr_cleanup: print out correct type

["Yinghai Lu" <yinghai@kernel.org>]

On Sat, Oct 4, 2008 at 5:42 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> Yinghai Lu wrote:
>>
>> Index: linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/main.c
>> +++ linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
>> @@ -1273,12 +1273,14 @@ static int __init mtrr_cleanup(unsigned
>>                size_base = to_size_factor(size_base, &size_factor),
>>                start_base = range_state[i].base_pfn << (PAGE_SHIFT - 10);
>>                start_base = to_size_factor(start_base, &start_factor),
>> +               type = range_state[i].type;
>>                  printk(KERN_DEBUG "reg %d, base: %ld%cB, range: %ld%cB,
>> type %s\n",
>>                        i, start_base, start_factor,
>>                        size_base, size_factor,
>>                        (type == MTRR_TYPE_UNCACHABLE) ? "UC" :
>> -                           ((type == MTRR_TYPE_WRBACK) ? "WB" : "Other")
>> +                           ((type == MTRR_TYPE_WRPROT) ? "WPROT" :
>> +                            ((type == MTRR_TYPE_WRBACK) ? "WB" :
>> "Other"))
>>                        );
>
> If you're going to abbreviate, please use the standard abbreviations as
> documented in the manuals.  The abbreviation for write protect is WP.
>
ok, will use WP.

YH