mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yinghai@kernel.org>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "James Bottomley" <James.Bottomley@hansenpartnership.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Jens Axboe" <Jens.Axboe@oracle.com>
Subject: Re: [PATCH] fix smp generic helper voyager breakage
Date: Mon, 10 Nov 2008 01:41:45 -0800	[thread overview]
Message-ID: <86802c440811100141k29d8f01dg7d279c3a0f85a184@mail.gmail.com> (raw)
In-Reply-To: <20081110093516.GK22392@elte.hu>

On Mon, Nov 10, 2008 at 1:35 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
>> From: James Bottomley <James.Bottomley@HansenPartnership.com>
>> Date: Wed, 29 Oct 2008 14:53:06 -0500
>> Subject: [VOYAGER] fix generic smp helpers non compile
>
> hm, i reported a bug to you with this patch on Oct 30.
>
>> commit 3d4422332711ef48ef0f132f1fcbfcbd56c7f3d1
>> Author: Jens Axboe <jens.axboe@oracle.com>
>> Date:   Thu Jun 26 11:21:34 2008 +0200
>>
>>     Add generic helpers for arch IPI function calls
>>
>> didn't wire up the voyager smp call function correctly, so do that
>> here.  Also make CONFIG_USE_GENERIC_SMP_HELPERS a def_bool y again,
>> since we now use the generic helpers for every x86 architecture.
>>
>> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
>> ---
>>  arch/x86/Kconfig                    |    5 ++++-
>>  arch/x86/mach-voyager/voyager_smp.c |   16 ++++++++++++++--
>>  2 files changed, 18 insertions(+), 3 deletions(-)
>
> no indication in the changelog whether that bug i reported got fixed -
> did it? (i suspect it did, but not sure)

should fix some voyager_smp.c compliing...

YH

  reply	other threads:[~2008-11-10  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 21:09 James Bottomley
2008-10-30 21:20 ` Ingo Molnar
2008-10-30 21:54 ` Ingo Molnar
2008-10-30 22:06   ` James Bottomley
2008-10-30 22:21     ` Ingo Molnar
2008-11-09 17:53       ` James Bottomley
2008-11-10  9:35         ` Ingo Molnar
2008-11-10  9:41           ` Yinghai Lu [this message]
2008-11-10 14:20           ` James Bottomley
2008-11-11 11:09         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440811100141k29d8f01dg7d279c3a0f85a184@mail.gmail.com \
    --to=yinghai@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Jens.Axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®