mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yinghai@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@elte.hu>
Cc: "Dimitri Sivanich" <sivanich@sgi.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, "john stultz" <johnstul@us.ibm.com>
Subject: Re: [PATCH 2/2 v3] SGI RTC: add generic timer system interrupt
Date: Fri, 21 Nov 2008 11:09:18 -0800	[thread overview]
Message-ID: <86802c440811211109l64a8a073n9515f1e17721114e@mail.gmail.com> (raw)
In-Reply-To: <4926FD58.7000406@zytor.com>

On Fri, Nov 21, 2008 at 10:26 AM, H. Peter Anvin <hpa@zytor.com> wrote:
> Dimitri Sivanich wrote:
>>
>> There are basically two issues with using 'normal IRQs' in cases like this:
>>
>> - Using normal IRQs would mean we would have an IRQ per cpu.  The current
>>   hard coded maximum, NR_IRQS, is 4352 (NR_VECTORS + (32 * MAX_IO_APICS)).
>>   On machines with large numbers of cpus and an irq per cpu for each desired
>>   interrupt, that's a lot of IRQs.  In addition, the GRU, will need 2 such
>>   IRQs per cpu.  On 4096 cpu systems, you've already used up more than the
>>   limit just for that.  Until some sort of infrastructure change takes place
>>   that would potentially allow this to be dynamically increased, such as
>>   Yinghai Lu's "sparse_irq aka dyn_irq v14" patch, this problem will exist.
>>
>>   Furthermore, the actual runtime limit, nr_irqs, is set to 96 by
>>   probe_nr_irqs for our configuration.  This is because that code assumes all
>>   vectors are io-apic vectors, not cpu centric vectors like the ones I'm
>>   talking about.  With the current, scheme, even on a 128 cpu system, I'm out
>>   of IRQs immediately.
>>
>> - The current infrastructure for requesting vector/IRQ combinations doesn't
>>   allow one to request an interrupt priority higher than i/o device interrupt
>>   priorities.  Clock event (high resolution timer) code should run at higher
>>   interrupt priority.
>
> Okay, so it is a hack pending us taking care of issues in the current
> code.  #1 we're obviously working on, #2 I need to think some more about
> but shouldn't be too hard to fix -- if real, it also affects other
> interrupt-driven clock sources.

should just remove probe_nr_irqs.

YH

  reply	other threads:[~2008-11-21 19:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23 16:30 [PATCH 0/2 v2] SGI RTC: add clocksource/clockevent driver Dimitri Sivanich
2008-10-23 16:32 ` [PATCH 1/2 v2] SGI RTC: add clocksource driver Dimitri Sivanich
2008-10-23 16:34   ` [PATCH 2/2 v2] SGI RTC: add RTC system interrupt Dimitri Sivanich
2008-10-24  3:11     ` [PATCH 2/2 v3] " Dimitri Sivanich
2008-10-27 14:08       ` Ingo Molnar
2008-10-27 15:29         ` Dimitri Sivanich
2008-11-19 21:22 ` [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver and generic timer vector Dimitri Sivanich
2008-11-19 21:23   ` [PATCH 1/2 v3] SGI RTC: add clocksource driver Dimitri Sivanich
2008-11-19 21:26     ` [PATCH 2/2 v3] SGI RTC: add generic timer system interrupt Dimitri Sivanich
2008-11-20 23:12       ` Andrew Morton
2008-11-20 23:19         ` H. Peter Anvin
2008-11-21 17:15           ` Dimitri Sivanich
2008-11-21 18:26             ` H. Peter Anvin
2008-11-21 19:09               ` Yinghai Lu [this message]
2008-11-23 13:36               ` Ingo Molnar
2008-11-21 17:21         ` Dimitri Sivanich
2008-11-20 23:08     ` [PATCH 1/2 v3] SGI RTC: add clocksource driver Andrew Morton
2008-11-21  0:08       ` john stultz
2008-11-21 17:23         ` Dimitri Sivanich
2008-11-20  9:59   ` [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver and generic timer vector Ingo Molnar
2008-11-21  1:44     ` H. Peter Anvin
2008-11-21  8:06       ` Ingo Molnar
2008-11-21 17:16       ` Dimitri Sivanich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440811211109l64a8a073n9515f1e17721114e@mail.gmail.com \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sivanich@sgi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®