From: Yinghai Lu <yinghai@kernel.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ingo Molnar <mingo@elte.hu>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: expose enable_IO_APIC for 32-bit
Date: Wed, 11 Feb 2009 00:36:38 -0800 [thread overview]
Message-ID: <86802c440902110036n4e0b2a55udee3e0d31e93f6e5@mail.gmail.com> (raw)
In-Reply-To: <bf56957d176c279175464f385f3eb03d65819328.1234296039.git.jeremy.fitzhardinge@citrix.com>
On Mon, Feb 9, 2009 at 12:05 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
> enable_IO_APIC() is defined for both 32- and 64-bit x86, so it should
> be declared for both.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> arch/x86/include/asm/hw_irq.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/hw_irq.h b/arch/x86/include/asm/hw_irq.h
> index 1b82781..370e1c8 100644
> --- a/arch/x86/include/asm/hw_irq.h
> +++ b/arch/x86/include/asm/hw_irq.h
> @@ -65,9 +65,7 @@ extern void disable_IO_APIC(void);
> extern int IO_APIC_get_PCI_irq_vector(int bus, int slot, int fn);
> extern void setup_ioapic_dest(void);
>
> -#ifdef CONFIG_X86_64
> extern void enable_IO_APIC(void);
> -#endif
>
> /* Statistics */
> extern atomic_t irq_err_count;
> --
> 1.6.0.6
>
> --
wonder if we should call enable_IO_APIC in 32bit like 64bit...
should be ok.
YH
next prev parent reply other threads:[~2009-02-11 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 20:00 [PATCH] *** SUBJECT HERE *** Jeremy Fitzhardinge
2009-02-09 20:05 ` [PATCH] x86: make apic_* operations inline functions Jeremy Fitzhardinge
2009-02-09 20:05 ` [PATCH] x86: add mp_find_ioapic_pin Jeremy Fitzhardinge
2009-02-09 20:05 ` [PATCH] x86: unstatic ioapic entry funcs Jeremy Fitzhardinge
2009-02-09 20:05 ` [PATCH] x86: unstatic mp_find_ioapic so it can be used elsewhere Jeremy Fitzhardinge
2009-02-09 20:05 ` [PATCH] xen: expose enable_IO_APIC for 32-bit Ian Campbell
2009-02-11 8:36 ` Yinghai Lu [this message]
2009-02-11 9:51 ` apic cleanups Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440902110036n4e0b2a55udee3e0d31e93f6e5@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®