From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbZBUIb4 (ORCPT ); Sat, 21 Feb 2009 03:31:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752219AbZBUIbq (ORCPT ); Sat, 21 Feb 2009 03:31:46 -0500 Received: from rv-out-0506.google.com ([209.85.198.233]:50227 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbZBUIbo (ORCPT ); Sat, 21 Feb 2009 03:31:44 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=QZpr4hhO1FqLYuOn06D5zhcnd5kEmRn2lBeV9bSK36b5jDI0+CCa5DY/lKn7SLB1/j 925cyNgnC9VVtb1kT9JxU0pGxOH7ff5qHALGoXHuzB26s3fubJyPNo+iX8PWzU/aI/XK IQe+PyQHBYxBZcYGVqsuzdZOiJ8PllFZ7MjYo= MIME-Version: 1.0 In-Reply-To: References: <499B724A.2040408@kernel.org> <499B774C.5010705@kernel.org> <499B9129.50104@kernel.org> <499CD466.1060900@gmail.com> Date: Sat, 21 Feb 2009 00:31:43 -0800 X-Google-Sender-Auth: f369be4046bcc6a8 Message-ID: <86802c440902210031j698403cev2147e72a61e17194@mail.gmail.com> Subject: Re: [PATCH] pci: enable MSI on 8132 From: Yinghai Lu To: "Eric W. Biederman" Cc: Robert Hancock , Jesse Barnes , Andrew Morton , david@lang.hm, Matthew Wilcox , linux-kernel , linux-scsi@vger.kernel.org, DL-MPTFusionLinux@lsi.com, linux-pci@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 20, 2009 at 11:50 PM, Eric W. Biederman wrote: > Robert Hancock writes: >> >> Is there a reason why we can't just enable the HT MSI mapping for any bridge >> device that has that PCI capability and is underneath an HT bridge? > > The code should be under CONFIG_X86 because the rules for enabling HT MSI mappings > are different for other architectures. But otherwise I can't think of a reason. move to arch/x86/pci/fixup.c? it seems some other arch do support HT ... powerpc, mips? > >> Essentially >> the code for nv_msi_ht_cap_quirk could potentially be applied to all bridges as >> it is currently for NVIDIA and ALi bridges.. > > Sounds like it would save a fair amount of grief. it seems there is some difference. 8132 is some kind of HT tunnel, and the bridge is acctually pci-x bridge. mcp55 and ck804: is HT end device with several pcie bridges. also 8131 has problem with HT MSI? YH