From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] Enable GART-IOMMU only after setting up protection methods
Date: Wed, 8 Apr 2009 21:44:07 -0700 [thread overview]
Message-ID: <86802c440904082144m54e2dba5n6c89624481fb5fa1@mail.gmail.com> (raw)
In-Reply-To: <200904081608.55746.mark.langsdorf@amd.com>
On Wed, Apr 8, 2009 at 2:08 PM, Mark Langsdorf <mark.langsdorf@amd.com> wrote:
> The current code to set up the GART as an IOMMU enables GART
> translations before it removes the aperture from the kernel
> memory map, sets the GART PTEs to UC, sets up the guard and
> scratch pages, or does a wbinvd(). This leaves the possibility
> of cache aliasing open and can cause system crashes.
>
> Re-order the code and add tlbflush so as to enable the
> GART translations only after all safeguards are in place and
> the tlb has been flushed.
>
> AMD has tested this patch and seen no adverse effects.
how about system with AGP card and more than 4g system RAM?
also it seems flush_gart() in init_k8_gatt() and gart_iommu_init()
could be removed?
YH
next prev parent reply other threads:[~2009-04-09 4:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 19:57 [PATCH][retry 5] Conform L3 Cache Index Disable to Linux Standards Mark Langsdorf
2009-03-19 8:18 ` Ingo Molnar
2009-04-08 21:02 ` [PATCH][retry 6] " Mark Langsdorf
2009-04-09 3:46 ` Ingo Molnar
2009-04-09 9:48 ` Andreas Herrmann
2009-04-08 21:08 ` [PATCH] Enable GART-IOMMU only after setting up protection methods Mark Langsdorf
2009-04-09 4:44 ` Yinghai Lu [this message]
2009-04-09 16:48 ` Langsdorf, Mark
2009-04-09 12:27 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440904082144m54e2dba5n6c89624481fb5fa1@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®