mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Matt Domsch <Matt_Domsch@dell.com>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
	Tom Long Nguyen <tom.l.nguyen@intel.com>,
	Zhang Yanmin <yanmin.zhang@intel.com>,
	linux-kernel@vger.kernel.org,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Huong_Nguyen@dell.com
Subject: Re: [PATCH] PCIe AER: honor ACPI HEST FIRMWARE FIRST mode
Date: Wed, 4 Nov 2009 12:55:50 -0800	[thread overview]
Message-ID: <86802c440911041255i59024efckf496dfa966da8560@mail.gmail.com> (raw)
In-Reply-To: <20091104091106.32489ad7@jbarnes-piketon>

On Wed, Nov 4, 2009 at 9:11 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Mon, 2 Nov 2009 11:51:24 -0600
> Matt Domsch <Matt_Domsch@dell.com> wrote:
>
>> From 97ec121f91e5c76dc037f8d2abaea84c5476676e Mon Sep 17 00:00:00 2001
>> From: Matt Domsch <Matt_Domsch@dell.com>
>> Date: Thu, 8 Oct 2009 23:18:11 -0500
>> Subject: [PATCH] PCIe AER: honor ACPI HEST FIRMWARE FIRST mode
>>
>> Feedback from Hidetoshi Seto and Kenji Kaneshige incorporated.  This
>> correctly handles PCI-X bridges, PCIe root ports and endpoints, and
>> prints debug messages when invalid/reserved types are found in the
>> HEST.  PCI devices not in domain/segment 0 are not represented in
>> HEST, thus will be ignored.
>>
>> Today, the PCIe Advanced Error Reporting (AER) driver attaches itself
>> to every PCIe root port for which BIOS reports it should, via ACPI
>> _OSC.
>>
>> However, _OSC alone is insufficient for newer BIOSes.  Part of ACPI
>> 4.0 is the new APEI (ACPI Platform Error Interfaces) which is a way
>> for OS and BIOS to handshake over which errors for which components
>> each will handle.  One table in ACPI 4.0 is the Hardware Error Source
>> Table (HEST), where BIOS can define that errors for certain PCIe
>> devices (or all devices), should be handled by BIOS ("Firmware First
>> mode"), rather than be handled by the OS.
>>
>> Dell PowerEdge 11G server BIOS defines Firmware First mode in HEST, so
>> that it may manage such errors, log them to the System Event Log, and
>> possibly take other actions.  The aer driver should honor this, and
>> not attach itself to devices noted as such.
>>
>> Furthermore, Kenji Kaneshige reminded us to disallow changing the AER
>> registers when respecting Firmware First mode.  Platform firmware is
>> expected to manage these, and if changes to them are allowed, it could
>> break that firmware's behavior.
>>
>> The HEST parsing code may be replaced in the future by a more
>> feature-rich implementation.  This patch provides the minimum needed
>> to prevent breakage until that implementation is available.
>>
>> Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>
>> ---
>
> Applied to my linux-next branch, thanks.
>

can not find acpi_hest.c and acpi_hest.h

maybe need to wait acpi hest code is there?

YH

  reply	other threads:[~2009-11-04 20:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06 17:33 Matt Domsch
2009-10-08  0:59 ` Hidetoshi Seto
     [not found] ` <851fc09e0910082221q7f832c22xfc0d01ab72a97c3f@mail.gmail.com>
2009-10-09  5:55   ` Fwd: " Huang Ying
2009-10-09 14:31     ` Matt Domsch
2009-10-09  7:11 ` Kenji Kaneshige
2009-10-09 18:28   ` Matt Domsch
2009-10-09 18:33     ` Matt Domsch
2009-10-29 14:15       ` Matt Domsch
2009-10-29 16:48         ` Jesse Barnes
2009-10-30  2:16       ` Hidetoshi Seto
2009-10-30  2:53         ` Matt Domsch
2009-10-30  3:24           ` Hidetoshi Seto
2009-11-02 17:51             ` Matt Domsch
2009-11-04 17:11               ` Jesse Barnes
2009-11-04 20:55                 ` Yinghai Lu [this message]
2009-11-04 21:05                   ` Jesse Barnes
2009-11-04 21:07                     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440911041255i59024efckf496dfa966da8560@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=Huong_Nguyen@dell.com \
    --cc=Matt_Domsch@dell.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tom.l.nguyen@intel.com \
    --cc=yanmin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®