mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Dave Jones <davej@redhat.com>, Yinghai Lu <yhlu.kernel@gmail.com>,
	mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, mingo@elte.hu,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/debug] x86: Minimise printk spew from per-vendor init  code
Date: Fri, 13 Nov 2009 18:48:58 -0800	[thread overview]
Message-ID: <86802c440911131848o2cccb056x32a819634c6855d9@mail.gmail.com> (raw)
In-Reply-To: <20091114013856.GB21609@redhat.com>

On Fri, Nov 13, 2009 at 5:38 PM, Dave Jones <davej@redhat.com> wrote:
> On Fri, Nov 13, 2009 at 05:03:44PM -0800, Yinghai Lu wrote:
>
>  > > --- a/arch/x86/kernel/cpu/common.c
>  > > +++ b/arch/x86/kernel/cpu/common.c
>  > > @@ -656,6 +656,7 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
>  > >
>  > >  void __init early_cpu_init(void)
>  > >  {
>  > > +#ifdef PROCESSOR_SELECT
>  > >        const struct cpu_dev *const *cdev;
>  > >        int count = 0;
>  > >
>  > > @@ -676,7 +677,7 @@ void __init early_cpu_init(void)
>  > >                                cpudev->c_ident[j]);
>  > >                }
>  > >        }
>  > > -
>  > > +#endif
>  > >        early_identify_cpu(&boot_cpu_data);
>  > >  }
>  >
>  > NACK.
>  >
>  > the function is initializing cpu_devs array.
>
> Ugh, I don't know how I missed that.  I also seem to have boot tested the wrong kernel.
> Back to the drawing board.
>
use two loop instead?

YH

  reply	other threads:[~2009-11-14  2:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 20:30 [X86] " Dave Jones
2009-11-14  0:33 ` [tip:x86/debug] x86: " tip-bot for Dave Jones
2009-11-14  1:03   ` Yinghai Lu
2009-11-14  1:38     ` Dave Jones
2009-11-14  2:48       ` Yinghai Lu [this message]
2009-11-14  9:38     ` Ingo Molnar
2009-11-14 10:19 ` [tip:x86/debug] x86: Fix cpu_devs[] initialization in early_cpu_init() tip-bot for Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440911131848o2cccb056x32a819634c6855d9@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=davej@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®