From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D0F1553AA for ; Mon, 30 Dec 2024 07:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735544935; cv=none; b=h89u61vsKkDtStZlvcpSzAyWPcMOjP669WJPoElDDr7uftn8M25YXx75pD89FvgFO7Wb+B1R53qLbd1m1lX5zFSPcQUkBMBTVOwlDnUi2wPgLf8zkEVVvNp0SXtbNlNYH3bgb5X95gzO6wRQL3Bl0tRaDs513nA0iyMV1hNN1Ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735544935; c=relaxed/simple; bh=9lBMs0Ul5wQCiw8Sc7Z2zieC30Xesh+V0rLSxzovXSk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=aoBwCIyPnbg3dOfMkazr71XRwYURRcTd5ZwKuFUfNOYg4JE/OynsuDtkiyHa9/+UwYUGOabrnga/nME6HdVi12Pjz9lXhGnCYv/Yjd7CbEnIM4LwMZ4FVVqtNS2Md34iQFKPAvUZ6PNm1yGMDZ+bQTaeG0cVv6VDJchySbMP79w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=eEKagQuo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="eEKagQuo" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BU7G9EF027922; Mon, 30 Dec 2024 07:48:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9lBMs0Ul5wQCiw8Sc7Z2zieC30Xesh+V0rLSxzovXSk=; b=eEKagQuoKHFeLYmv +5rAlpvEkTrmQJKObjSHAQvteoakjIEOD1R452rvBxZho5m0BjdB0C04K1ALX4rQ 9o433NgW368Y5MpuLea0TOH8sqgZByi3EVpTXM8l+F4E5Qu4zKzgAWu9dk43O79k oSSlGiRm9VbJ8r72IKU8c2icP2lapDpOG33wEmW+IbNWjGsJmVj5uowwvzxepy81 dmiiDWjyLoqVKAogFlvRDvMmCNs7WwfzQAxPr6UQHEA5zpf3wiXQsOT0lnXWhTmP TlwLKVdw8zoacdocd9jgWq3KHNTPP+gbXgUww1bZWLheau8hAbpNvAIXsl631JUY cn3Iog== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43upyr81tk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Dec 2024 07:48:38 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BU7mbds012157 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Dec 2024 07:48:37 GMT Received: from [10.239.132.245] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sun, 29 Dec 2024 23:48:34 -0800 Message-ID: <8685ca94-1382-45c0-a3c3-4b5ccf244057@quicinc.com> Date: Mon, 30 Dec 2024 15:48:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: mm: implement vmemmap_check_pmd for arm64 To: Anshuman Khandual , Catalin Marinas CC: , , , , , , , , , , , References: <20241209094227.1529977-1-quic_zhenhuah@quicinc.com> <20241209094227.1529977-3-quic_zhenhuah@quicinc.com> <39a85800-47c5-4529-906d-5a40e58ce136@arm.com> Content-Language: en-US From: Zhenhua Huang In-Reply-To: <39a85800-47c5-4529-906d-5a40e58ce136@arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 05vQ5z3ocu6WtEGIJq_QrSThdYzcr5BL X-Proofpoint-ORIG-GUID: 05vQ5z3ocu6WtEGIJq_QrSThdYzcr5BL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=396 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412300065 On 2024/12/27 10:57, Anshuman Khandual wrote: > However it does not really check the entry to be a section mapping which it should. > Returning pmd_sect(READ_ONCE(*pmdp)) is the right thing, which should have been the > case from the beginning when vmemmap_check_pmd() was added. I guess because arm64's > original vmemmap_populate() checked only for vmemmap_verify() as well. So probably > this does not need a "Fixes: " tag. Hi Anshuman, I agree, will remove "Fixes: " tag in next patchset