From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798AA1EE036 for ; Tue, 21 Jan 2025 10:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737455392; cv=none; b=VUjJgumXjc8eHQLvojR0TG0+fG2Kdhemo+5WoB/FZqBcBT+Qqsbk0f7AyH/GrelrZ9gZK1qABvBBYF4lUxjFcRfUOclBoqzFyTSUluxcsYyNIeR3zsK+mNC2AG5JiPSnrxQnBxwl1lThydru/JOXs+jsiXQl91/Cd2v557DktvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737455392; c=relaxed/simple; bh=6AaEQjUILhJ/z5XoYOm9MEfL8ZC3WYBp67J1RrUglT8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p6gup6nDH4sSoARlCygaETcYzxFG0qLx4OACdvXvHwbhSGyyXgD1spTlncDTMPNXPcEuSa18sQX338cJTZTcZt0qsrumAPG5OGbrOnL3O1O8j9Aq4IOCFMlU4zvG1WSuQfuaSs7/b3/DZYOFQjYTSRMnpiCK3RokxrZg/8vU+wY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=QO7iuEmW; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="QO7iuEmW" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-385f06d0c8eso2862609f8f.0 for ; Tue, 21 Jan 2025 02:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1737455388; x=1738060188; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tREQSbIeCuUUo6kw7V1GF3H9V+/GJnzAykBmE1L7QF8=; b=QO7iuEmWoihMKxcpCUSyGG3qYpdcdYYsptqpM2GW8vTzztpMc1N2ESu7UFeCBJJGvG L/RpXQa87xU+8pwHzp1OPDjmA6Ujfcv6eLoB80UWYXd7KCiwZJOfykju3LbRxQpLNJvH 0Eh4x1TAjvjwiZMi6/y97nabST67AClFZsoGv/XV7jNdKu1Tudqsf7VYj7TzVqn12N41 cwVKhUpuoLg2WOS6tnKZ9fG8cE3WA5zoJKtnSG/ePgb7VVhnOi0imZl+Pu47riRq4fIx GgiXUzxXQURFqs/3GR6bMTtkq6sl3Jqoc4H+jkieuUlnGczcsiwrJXT9fT2mg+8dtm8k j9yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737455388; x=1738060188; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tREQSbIeCuUUo6kw7V1GF3H9V+/GJnzAykBmE1L7QF8=; b=Sf/zarqdGkTgTx8msdpgz9h6O9PugZZbFC1eTS/iJTzgs4Sg5UnpQFpaJt7Wbw0dCS NEy4OnnlSuL9W1sVkxyBvM9GKEhdMY2CxPoeF3mcUtImmAVvJmrsbUSEurSjAXCjEANn +SdpOHnV8XeOVQ5Sff33ekyguiam7i/acRKA8caBIAU3TLNIE8wfGmc6oVqVK9iT+5/F B6DcV6Uj6auhRNArlGpbvOGbozVAbQE6zRWNsmXLzJQBtD0qIlWej5v8udU49IUG73xK pg8P0u/q8T5LSOFWeomBbD94H1fQGgFJVAglb/yw3+s3wjUqchGb+MZmOGGO7wvwRHn6 DlRQ== X-Forwarded-Encrypted: i=1; AJvYcCU/r/hfCPj/r5NH2UPd0vhuAUwFiL6UkP3pkLFSC2rWUidGwwZzRNnIiIf7u25ciGEjc5D8Nev34f15MvI=@vger.kernel.org X-Gm-Message-State: AOJu0Yybg+OBgYGnxtl9eugC3AnAgQcO3aqm0Qf/XMQ8Vac/VX+rarjm 7xf1m53tzQqk17SZaVuD8dkAt0NKtjnkCHaZhUOkiHbcy3e8XLMnxfbb0yPbN9c= X-Gm-Gg: ASbGncsF8PkioXTh23c93RsdfUcCZGY4F1NIdR+iSL3ZTySfCt37V1v0tTwmhvLIpIO 7B2JFkwv09CiOpUAZMPyFeQ8IONA8V0Axeg1ofcl1Q2veBa4eaAhuSIfSyVdJlD/J0NqK0GCxtr zg3HOXK4WOeFnGEbMDp52+5E7IaWSH4ihq0+AS1Rk03bMcxOYdFyPJA6aIO8tsnj6EMADV2MgoM Wke9dfEMcGL+1hlPzBkcWWXwwMzkuISIYo+buSnyb2ulYeEL9WsNs3MS6kzUEdbnDjneEPo8vq+ kQ== X-Google-Smtp-Source: AGHT+IH8fxLpytjbLVapxMjdNWG42y58FtVvI1kFX2ItvgsyT/3cMg7QIndqQ1oqiTRwrzLAHF+Waw== X-Received: by 2002:a5d:4e52:0:b0:38a:88bc:aea4 with SMTP id ffacd0b85a97d-38bf57a2304mr9740432f8f.30.1737455388545; Tue, 21 Jan 2025 02:29:48 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf322b51bsm13148526f8f.60.2025.01.21.02.29.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 02:29:48 -0800 (PST) Message-ID: <8686406e-6124-483e-af87-cc40e4d760b1@tuxon.dev> Date: Tue, 21 Jan 2025 12:29:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: phy: Fix suspicious rcu_dereference usage To: Kory Maincent , Jakub Kicinski Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , thomas.petazzoni@bootlin.com, Andrew Lunn , Heiner Kallweit , Russell King , Eric Dumazet , Paolo Abeni References: <20250120141926.1290763-1-kory.maincent@bootlin.com> <20250120111228.6bd61673@kernel.org> <20250121103845.6e135477@kmaincent-XPS-13-7390> From: Claudiu Beznea Content-Language: en-US In-Reply-To: <20250121103845.6e135477@kmaincent-XPS-13-7390> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Kory, On 21.01.2025 11:38, Kory Maincent wrote: > On Mon, 20 Jan 2025 11:12:28 -0800 > Jakub Kicinski wrote: > >> On Mon, 20 Jan 2025 15:19:25 +0100 Kory Maincent wrote: >>> The path reported to not having RTNL lock acquired is the suspend path of >>> the ravb MAC driver. Without this fix we got this warning: >> >> I maintain that ravb is buggy, plenty of drivers take rtnl_lock >> from the .suspend callback. We need _some_ write protection here, >> the patch as is only silences a legitimate warning. > > Indeed if the suspend path is buggy we should fix it. Still there is lots of > ethernet drivers calling phy_disconnect without rtnl (IIUC) if probe return an > error or in the remove path. What should we do about it? > > About ravb suspend, I don't have the board, Claudiu could you try this instead > of the current fix: > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > b/drivers/net/ethernet/renesas/ravb_main.c index bc395294a32d..c9a0d2d6f371 > 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -3215,15 +3215,22 @@ static int ravb_suspend(struct device *dev) > if (!netif_running(ndev)) > goto reset_assert; > > + rtnl_lock(); > netif_device_detach(ndev); > > - if (priv->wol_enabled) > - return ravb_wol_setup(ndev); > + if (priv->wol_enabled) { > + ret = ravb_wol_setup(ndev); > + rtnl_unlock(); > + return ret; > + } > > ret = ravb_close(ndev); > - if (ret) > + if (ret) { > + rtnl_unlock(); > return ret; > + } > > + rtnl_unlock(); > ret = pm_runtime_force_suspend(&priv->pdev->dev); > if (ret) > return ret; The warning is gone with this, as well. Thank you, Claudiu > > Regards,