Re: [PATCH v2 2/4] media: uapi: Cleanup tab after define in headers

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 6214 bytes --]

Le dimanche 24 août 2025 à 20:07 +0200, Paul Kocialkowski a écrit :
> Some definitions use a tab after the define keyword instead of the
> usual single space. Replace it for better consistency.
> 
> Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  include/uapi/linux/v4l2-controls.h | 30 +++++++++++++++---------------
>  include/uapi/linux/videodev2.h     | 18 +++++++++---------
>  2 files changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-
> controls.h
> index 4a483ff1c418..7aef88465d04 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -1193,7 +1193,7 @@ enum v4l2_flash_strobe_source {
>  #define V4L2_CID_JPEG_CLASS_BASE		(V4L2_CTRL_CLASS_JPEG |
> 0x900)
>  #define V4L2_CID_JPEG_CLASS			(V4L2_CTRL_CLASS_JPEG | 1)
>  
> -
> #define	V4L2_CID_JPEG_CHROMA_SUBSAMPLING	(V4L2_CID_JPEG_CLASS_BASE + 1)
> +#define V4L2_CID_JPEG_CHROMA_SUBSAMPLING	(V4L2_CID_JPEG_CLASS_BASE +
> 1)
>  enum v4l2_jpeg_chroma_subsampling {
>  	V4L2_JPEG_CHROMA_SUBSAMPLING_444	= 0,
>  	V4L2_JPEG_CHROMA_SUBSAMPLING_422	= 1,
> @@ -1202,15 +1202,15 @@ enum v4l2_jpeg_chroma_subsampling {
>  	V4L2_JPEG_CHROMA_SUBSAMPLING_410	= 4,
>  	V4L2_JPEG_CHROMA_SUBSAMPLING_GRAY	= 5,
>  };
> -
> #define	V4L2_CID_JPEG_RESTART_INTERVAL		(V4L2_CID_JPEG_CLASS_BASE + 2)
> -
> #define	V4L2_CID_JPEG_COMPRESSION_QUALITY	(V4L2_CID_JPEG_CLASS_BASE + 3)
> +#define V4L2_CID_JPEG_RESTART_INTERVAL		(V4L2_CID_JPEG_CLASS_BASE +
> 2)
> +#define V4L2_CID_JPEG_COMPRESSION_QUALITY	(V4L2_CID_JPEG_CLASS_BASE +
> 3)
>  
> -
> #define	V4L2_CID_JPEG_ACTIVE_MARKER		(V4L2_CID_JPEG_CLASS_BASE + 4)
> -#define	V4L2_JPEG_ACTIVE_MARKER_APP0		(1 << 0)
> -#define	V4L2_JPEG_ACTIVE_MARKER_APP1		(1 << 1)
> -#define	V4L2_JPEG_ACTIVE_MARKER_COM		(1 << 16)
> -#define	V4L2_JPEG_ACTIVE_MARKER_DQT		(1 << 17)
> -#define	V4L2_JPEG_ACTIVE_MARKER_DHT		(1 << 18)
> +#define V4L2_CID_JPEG_ACTIVE_MARKER		(V4L2_CID_JPEG_CLASS_BASE +
> 4)
> +#define V4L2_JPEG_ACTIVE_MARKER_APP0		(1 << 0)
> +#define V4L2_JPEG_ACTIVE_MARKER_APP1		(1 << 1)
> +#define V4L2_JPEG_ACTIVE_MARKER_COM		(1 << 16)
> +#define V4L2_JPEG_ACTIVE_MARKER_DQT		(1 << 17)
> +#define V4L2_JPEG_ACTIVE_MARKER_DHT		(1 << 18)
>  
>  
>  /* Image source controls */
> @@ -1243,10 +1243,10 @@ enum v4l2_jpeg_chroma_subsampling {
>  #define V4L2_CID_DV_CLASS_BASE			(V4L2_CTRL_CLASS_DV | 0x900)
>  #define V4L2_CID_DV_CLASS			(V4L2_CTRL_CLASS_DV | 1)
>  
> -
> #define	V4L2_CID_DV_TX_HOTPLUG			(V4L2_CID_DV_CLASS_BASE + 1)
> -
> #define	V4L2_CID_DV_TX_RXSENSE			(V4L2_CID_DV_CLASS_BASE + 2)
> -
> #define	V4L2_CID_DV_TX_EDID_PRESENT		(V4L2_CID_DV_CLASS_BASE + 3)
> -
> #define	V4L2_CID_DV_TX_MODE			(V4L2_CID_DV_CLASS_BASE + 4)
> +#define V4L2_CID_DV_TX_HOTPLUG			(V4L2_CID_DV_CLASS_BASE + 1)
> +#define V4L2_CID_DV_TX_RXSENSE			(V4L2_CID_DV_CLASS_BASE + 2)
> +#define V4L2_CID_DV_TX_EDID_PRESENT		(V4L2_CID_DV_CLASS_BASE + 3)
> +#define V4L2_CID_DV_TX_MODE			(V4L2_CID_DV_CLASS_BASE + 4)
>  enum v4l2_dv_tx_mode {
>  	V4L2_DV_TX_MODE_DVI_D	= 0,
>  	V4L2_DV_TX_MODE_HDMI	= 1,
> @@ -1267,7 +1267,7 @@ enum v4l2_dv_it_content_type {
>  	V4L2_DV_IT_CONTENT_TYPE_NO_ITC	  = 4,
>  };
>  
> -
> #define	V4L2_CID_DV_RX_POWER_PRESENT		(V4L2_CID_DV_CLASS_BASE + 100)
> +#define V4L2_CID_DV_RX_POWER_PRESENT		(V4L2_CID_DV_CLASS_BASE +
> 100)
>  #define V4L2_CID_DV_RX_RGB_RANGE		(V4L2_CID_DV_CLASS_BASE +
> 101)
>  #define V4L2_CID_DV_RX_IT_CONTENT_TYPE		(V4L2_CID_DV_CLASS_BASE +
> 102)
>  
> @@ -2552,7 +2552,7 @@ struct v4l2_ctrl_hevc_scaling_matrix {
>  /* Stateless VP9 controls */
>  
>  #define V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED	0x1
> -#define	V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE	0x2
> +#define V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE	0x2
>  
>  /**
>   * struct v4l2_vp9_loop_filter - VP9 loop filter parameters
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 3dd9fa45dde1..64943f1a6149 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -1607,8 +1607,8 @@ struct v4l2_bt_timings {
>  } __attribute__ ((packed));
>  
>  /* Interlaced or progressive format */
> -#define	V4L2_DV_PROGRESSIVE	0
> -#define	V4L2_DV_INTERLACED	1
> +#define V4L2_DV_PROGRESSIVE	0
> +#define V4L2_DV_INTERLACED	1
>  
>  /* Polarities. If bit is not set, it is assumed to be negative polarity */
>  #define V4L2_DV_VSYNC_POS_POL	0x00000001
> @@ -2788,15 +2788,15 @@ struct v4l2_remove_buffers {
>   * Only implemented if CONFIG_VIDEO_ADV_DEBUG is defined.
>   * You must be root to use these ioctls. Never use these in applications!
>   */
> -#define	VIDIOC_DBG_S_REGISTER	 _IOW('V', 79, struct
> v4l2_dbg_register)
> -#define	VIDIOC_DBG_G_REGISTER	_IOWR('V', 80, struct
> v4l2_dbg_register)
> +#define VIDIOC_DBG_S_REGISTER	 _IOW('V', 79, struct v4l2_dbg_register)
> +#define VIDIOC_DBG_G_REGISTER	_IOWR('V', 80, struct v4l2_dbg_register)
>  
>  #define VIDIOC_S_HW_FREQ_SEEK	 _IOW('V', 82, struct v4l2_hw_freq_seek)
> -#define	VIDIOC_S_DV_TIMINGS	_IOWR('V', 87, struct
> v4l2_dv_timings)
> -#define	VIDIOC_G_DV_TIMINGS	_IOWR('V', 88, struct
> v4l2_dv_timings)
> -#define	VIDIOC_DQEVENT		 _IOR('V', 89, struct v4l2_event)
> -#define	VIDIOC_SUBSCRIBE_EVENT	 _IOW('V', 90, struct
> v4l2_event_subscription)
> -#define	VIDIOC_UNSUBSCRIBE_EVENT _IOW('V', 91, struct
> v4l2_event_subscription)
> +#define VIDIOC_S_DV_TIMINGS	_IOWR('V', 87, struct v4l2_dv_timings)
> +#define VIDIOC_G_DV_TIMINGS	_IOWR('V', 88, struct v4l2_dv_timings)
> +#define VIDIOC_DQEVENT		 _IOR('V', 89, struct v4l2_event)
> +#define VIDIOC_SUBSCRIBE_EVENT	 _IOW('V', 90, struct
> v4l2_event_subscription)
> +#define VIDIOC_UNSUBSCRIBE_EVENT _IOW('V', 91, struct
> v4l2_event_subscription)
>  #define VIDIOC_CREATE_BUFS	_IOWR('V', 92, struct v4l2_create_buffers)
>  #define VIDIOC_PREPARE_BUF	_IOWR('V', 93, struct v4l2_buffer)
>  #define VIDIOC_G_SELECTION	_IOWR('V', 94, struct v4l2_selection)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]