From: Yu-cheng Yu <yu-cheng.yu@intel.com>
To: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>
Subject: [PATCH v2 9/9] x86/xsaves: Re-enable XSAVES
Date: Thu, 25 Feb 2016 12:26:20 -0800 [thread overview]
Message-ID: <8687eb3f43f4a2a4cc2c21f38c5f420631662fd3.1456420312.git.yu-cheng.yu@intel.com> (raw)
In-Reply-To: <cover.1456420312.git.yu-cheng.yu@intel.com>
In-Reply-To: <cover.1456420312.git.yu-cheng.yu@intel.com>
We did not handle XSAVES* instructions correctly. There were issues in
converting between standard and compacted format when interfacing with
user-space. These issues have been corrected.
Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
---
arch/x86/kernel/fpu/init.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/arch/x86/kernel/fpu/init.c b/arch/x86/kernel/fpu/init.c
index b5952d5..21e0d52 100644
--- a/arch/x86/kernel/fpu/init.c
+++ b/arch/x86/kernel/fpu/init.c
@@ -228,19 +228,11 @@ static void __init fpu__init_system_xstate_size_legacy(void)
user_xstate_size = kernel_xstate_size;
/*
- * Quirk: we don't yet handle the XSAVES* instructions
- * correctly, as we don't correctly convert between
- * standard and compacted format when interfacing
- * with user-space - so disable it for now.
- *
- * The difference is small: with recent CPUs the
- * compacted format is only marginally smaller than
- * the standard FPU state format.
- *
- * ( This is easy to backport while we are fixing
- * XSAVES* support. )
+ * Most recent CPUs supporting XSAVES can run 64-bit mode.
+ * Enable XSAVES for 64-bit.
*/
- setup_clear_cpu_cap(X86_FEATURE_XSAVES);
+ if (!config_enabled(CONFIG_X86_64))
+ setup_clear_cpu_cap(X86_FEATURE_XSAVES);
}
/*
--
1.9.1
next prev parent reply other threads:[~2016-02-25 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 20:26 [PATCH v2 0/9] x86/xsaves: Fix XSAVES known issues Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 1/9] x86/xsaves: Define and use user_xstate_size for xstate size in signal context Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 2/9] x86/xsaves: Rename xstate_size to kernel_xstate_size to explicitly distinguish xstate size in kernel from user space Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 3/9] x86/xsaves: Keep init_fpstate.xsave.header.xfeatures as zero for init optimization Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 4/9] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 5/9] x86/xsaves: Align xstate components according to CPUID Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 6/9] x86/xsaves: Supervisor state component offset Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 7/9] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu
2016-02-25 20:26 ` [PATCH v2 8/9] x86/xsaves: Fix XSTATE component offset print out Yu-cheng Yu
2016-02-25 20:26 ` Yu-cheng Yu [this message]
2016-02-25 20:34 ` [PATCH v2 9/9] x86/xsaves: Re-enable XSAVES Dave Hansen
2016-02-25 21:03 ` Yu-cheng Yu
2016-02-25 20:57 ` [PATCH v2 0/9] x86/xsaves: Fix XSAVES known issues Dave Hansen
2016-02-25 21:07 ` Yu-cheng Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8687eb3f43f4a2a4cc2c21f38c5f420631662fd3.1456420312.git.yu-cheng.yu@intel.com \
--to=yu-cheng.yu@intel.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®