From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757881AbdKOOqw (ORCPT ); Wed, 15 Nov 2017 09:46:52 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53542 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755719AbdKOOqp (ORCPT ); Wed, 15 Nov 2017 09:46:45 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B6DCE60310 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] PCI/AER: don't call recovery process for correctable errors To: Bjorn Helgaas Cc: bhelgaas@google.com, jonathan.derrick@intel.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <1503940184-29423-1-git-send-email-tbaicar@codeaurora.org> <20171002231903.GE5407@bhelgaas-glaptop.roam.corp.google.com> From: Tyler Baicar Message-ID: <86882a99-ef54-a71b-3e97-8ecc46d8d14b@codeaurora.org> Date: Wed, 15 Nov 2017 09:46:42 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171002231903.GE5407@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/2017 7:19 PM, Bjorn Helgaas wrote: > On Mon, Aug 28, 2017 at 11:09:44AM -0600, Tyler Baicar wrote: >> Correctable errors do not need any software intervention, so >> avoid calling into the software recovery process for correctable >> errors. >> >> Signed-off-by: Tyler Baicar >> --- >> drivers/pci/pcie/aer/aerdrv_core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c >> index b1303b3..4765c11 100644 >> --- a/drivers/pci/pcie/aer/aerdrv_core.c >> +++ b/drivers/pci/pcie/aer/aerdrv_core.c >> @@ -626,7 +626,8 @@ static void aer_recover_work_func(struct work_struct *work) >> continue; >> } >> cper_print_aer(pdev, entry.severity, entry.regs); >> - do_recovery(pdev, entry.severity); >> + if (entry.severity != AER_CORRECTABLE) >> + do_recovery(pdev, entry.severity); > I think this is fine, and it mirrors what is done in > handle_error_source(). > Hello, Will this patch be pulled into 4.15? Thanks, Tyler -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.