From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934744AbdKGAv2 (ORCPT ); Mon, 6 Nov 2017 19:51:28 -0500 Received: from mga07.intel.com ([134.134.136.100]:54243 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932702AbdKGAv0 (ORCPT ); Mon, 6 Nov 2017 19:51:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,355,1505804400"; d="scan'208";a="146689165" Subject: Re: [PATCH 4.13 10/36] PM / QoS: Fix default runtime_pm device resume latency To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Tero Kristo References: <20171106085047.005824077@linuxfoundation.org> <20171106085047.474486973@linuxfoundation.org> From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk Message-ID: <868c0cd2-fd9d-7efc-5dc2-64d7d5cfc5f1@intel.com> Date: Tue, 7 Nov 2017 01:51:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171106085047.474486973@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/2017 10:12 AM, Greg Kroah-Hartman wrote: > 4.13-stable review patch. If anyone has any objections, please let me know. Please drop this from the -stable queue, it has been reverted from the mainline. Thanks, Rafael > ------------------ > > From: Tero Kristo > > commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream. > > The recent change to the PM QoS framework to introduce a proper > no constraint value overlooked to handle the devices which don't > implement PM QoS OPS. Runtime PM is one of the more severely > impacted subsystems, failing every attempt to runtime suspend > a device. This leads into some nasty second level issues like > probe failures and increased power consumption among other > things. > > Fix this by adding a proper return value for devices that don't > implement PM QoS. > > Fixes: 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS) > Signed-off-by: Tero Kristo > Signed-off-by: Rafael J. Wysocki > Signed-off-by: Greg Kroah-Hartman > > --- > include/linux/pm_qos.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/include/linux/pm_qos.h > +++ b/include/linux/pm_qos.h > @@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f > static inline s32 dev_pm_qos_raw_read_value(struct device *dev) > { > return IS_ERR_OR_NULL(dev->power.qos) ? > - 0 : pm_qos_read_value(&dev->power.qos->resume_latency); > + PM_QOS_RESUME_LATENCY_NO_CONSTRAINT : > + pm_qos_read_value(&dev->power.qos->resume_latency); > } > #else > static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev, > >