From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B85F2475CB for ; Mon, 7 Sep 2026 17:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788803418; cv=none; b=CybA2uycBYRYU+Nr9m7C3C6Fu6yo+YmGhwMIOYi9scgJycmO/AGIT6+Z+A6hlqEyuL42b3kMN1qVNS3wKdv/4av1NDRVJ2YZRmopZ35+231PkzEwY+TT8A2x8VIKg+3eVxjqEqKmSjNalUihv5fd3TOqp0yTvdwzpWyR6Tz22FQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788803418; c=relaxed/simple; bh=9hQn/3/R4y5/GLB1rVl7wVcBchcJx8HdrOrtByILXL0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=r0JchPLvLZNXjM2uaC/QCr/QSkGWeRKER35RFQ/4Bn1a+NRlG56CXwyNTowRZ5PfrdjE5UDSKJmxDkbmz43m7WmQ2/1cnzxv+CESMQc9sG0A3f4wlC1f8AcwLZZD1JlFdshyi4iHwKmme+sXU8AJnN1qh0FSvPX4k83t9W7ZZ6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aXYBXV5L; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aXYBXV5L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4C641F00A3A; Mon, 7 Sep 2026 17:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788803416; bh=mllLkfa4j6cMDPeyNiMqsOMa/da1v2mEshsDPnTO6MA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=aXYBXV5LjCa95Ar1ahT4FkT0RH2hAHbboc+AU+af64jq11E0qdOIFR+n5DQ163Vz/ 86YbKPwrtq1aeFC1dB4U8tmOoaEuetTUakgi5wpWweH+D3oOdd0VrP+DMvF6/3MyFK jJOqBiKR8PDgMFadBfziaDQNuxALVK3y/RjOf24hDhDj1LL1+GjFlsMUxR2pwXM9kv hmJR5hZVreqCfqeSqzTXo989ClOLYdhxY7HHBO2d9hpyM652NjD77O2nwtjjMEMvN8 sSfXQL5PZM+I4eIYXdBOkws45gclWOPqd3M7fLGF59P435+u98dPXPeVhWv8PDHOlE pkcrqSKjgabrQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x3dTy-00000005tfl-3fb0; Mon, 07 Sep 2026 17:50:14 +0000 Date: Mon, 07 Sep 2026 18:50:14 +0100 Message-ID: <868q5d3q95.wl-maz@kernel.org> From: Marc Zyngier To: Sascha Bischoff Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , nd , "lpieralisi@kernel.org" , "tglx@kernel.org" , Catalin Marinas , "will@kernel.org" , Mark Rutland , Sashiko Subject: Re: [PATCH v2] irqchip/gic-v5: Preserve ICC_CR0_EL1 state In-Reply-To: <20260907164945.714545-1-sascha.bischoff@arm.com> References: <20260907164945.714545-1-sascha.bischoff@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: Sascha.Bischoff@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nd@arm.com, lpieralisi@kernel.org, tglx@kernel.org, Catalin.Marinas@arm.com, will@kernel.org, Mark.Rutland@arm.com, sashiko-bot@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 07 Sep 2026 17:49:50 +0100, Sascha Bischoff wrote: > > In addition to EN, ICC_CR0_EL1 contains other fields, such as LINK and > LINK_IDLE. The driver only needs to modify EN, and must preserve the > values of all other fields when enabling or disabling the CPU > interface. > > Define the missing LINK and LINK_IDLE fields, and use read-modify-write > accesses to update EN without affecting the rest of ICC_CR0_EL1. > > Fixes: 7ec80fb3f025 ("irqchip/gic-v5: Add GICv5 PPI support") > Reported-by: Sashiko > Closes: https://lore.kernel.org/r/20260807121703.D4B7A1F00A3A@smtp.kernel.org > Signed-off-by: Sascha Bischoff Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.