mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	the arch/x86 maintainers <x86@kernel.org>,
	<jailhouse-dev@googlegroups.com>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Juergen Gross <jgross@suse.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/jailhouse: fix building without X86_X2APIC
Date: Tue, 16 Jan 2018 16:17:42 +0800	[thread overview]
Message-ID: <86917190-5499-3fb8-7b5c-736dc2daeca5@cn.fujitsu.com> (raw)
In-Reply-To: <CAK8P3a2gnKcFmnzfKG=DTLh2UQ8bYa7F59hPqEgY77bYELw85g@mail.gmail.com>

Hi Arnd,

[...]
>> The reason I don't want to expose the x2apic_mode and x2apic_phys is
>> that they may be misused in X2APIC=n case. So I create an interface to
>> wrap it. do you think so? ;-)
> 
> I'm not sure I follow what the intention of that is. If you want to hide

My purpose of that is hiding the variables in X2APIC=n case.

> those two variables, maybe make them 'static' and remove the extern
> declarations?
> 

Yes, that's what I really want, But due to the simple "x2apic_phys= 1"
operation, doing that may be too fat, I guess.

>> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
>> index 98722773391d..ac25ac2e49af 100644
>> --- a/arch/x86/include/asm/apic.h
>> +++ b/arch/x86/include/asm/apic.h
>> @@ -251,6 +251,11 @@ static inline u64 native_x2apic_icr_read(void)
>>
>>   extern int x2apic_mode;
>>   extern int x2apic_phys;
>> +static inline void apic_set_x2apic_phys(void)
>> +{
>> +       x2apic_phys = 1;
>> +}
>> +
>>   extern void __init check_x2apic(void);
>>   extern void x2apic_setup(void);
>>   static inline int x2apic_enabled(void)
>> @@ -265,7 +270,10 @@ static inline void x2apic_setup(void) { }
>>   static inline int x2apic_enabled(void) { return 0; }
>>
>>   #define x2apic_mode            (0)
>> -#define        x2apic_supported()      (0)
>> +#define x2apic_phys            (0)
>> +#define x2apic_supported()     (0)
>> +
>> +static inline void apic_set_x2apic_phys(void){}
>>   #endif /* !CONFIG_X86_X2APIC */
>>
>>   struct irq_data;
> 
> I see nothing wrong it with this, but also don't see anything it does
> that improves the interface.
> 

Another way we can choice is wrap the code with "CONFIG_X86_X2APIC".

Thanks,
	dou
--------------------------------8<------------------------------------
diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c
index d6d5976a9b51..d4aee43c8912 100644
--- a/arch/x86/kernel/jailhouse.c
+++ b/arch/x86/kernel/jailhouse.c
@@ -65,6 +65,7 @@ static void __init jailhouse_get_smp_config(unsigned 
int early)
         };
         unsigned int cpu;

+#ifdef CONFIG_X86_X2APIC
         if (x2apic_enabled()) {
                 /*
                  * We do not have access to IR inside Jailhouse 
non-root cells.
@@ -79,6 +80,7 @@ static void __init jailhouse_get_smp_config(unsigned 
int early)
                  */
                 default_acpi_madt_oem_check("", "");
         }
+#endif

         register_lapic_address(0xfee00000);

>        Arnd
> 
> 
> 

  reply	other threads:[~2018-01-16  8:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 20:23 Arnd Bergmann
2018-01-16  1:25 ` Dou Liyang
2018-01-16  2:34   ` Dou Liyang
2018-01-16  7:21     ` Arnd Bergmann
2018-01-16  8:17       ` Dou Liyang [this message]
2018-01-16  8:50         ` Arnd Bergmann
2018-01-16 11:02           ` Dou Liyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86917190-5499-3fb8-7b5c-736dc2daeca5@cn.fujitsu.com \
    --to=douly.fnst@cn.fujitsu.com \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=jailhouse-dev@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®