From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751250AbdJDTzf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 15:55:35 -0400
Received: from mout.web.de ([212.227.15.14]:54481 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751135AbdJDTzd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 15:55:33 -0400
Subject: Re: cris: nand: Delete an error message for a failed memory
 allocation in crisv32_nand_flash_probe()
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        linux-cris-kernel@axis.com
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Krzysztof Halasa <khalasa@piap.pl>, Mikael Starvik <starvik@axis.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Shawn Guo <shawnguo@kernel.org>, Tony Lindgren <tony@atomide.com>,
        Vladimir Zapolskiy <vz@mleia.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <cd84411c-d202-70d6-dec2-c02bedaf3594@users.sourceforge.net>
 <92a95fe3-5b8d-5dd9-a7bf-131a999e74c6@users.sourceforge.net>
 <20171004214432.20833a0ff3b9c8fdced2ebaa@gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <86983988-9ede-09f8-2914-25c09699be67@users.sourceforge.net>
Date: Wed, 4 Oct 2017 21:55:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171004214432.20833a0ff3b9c8fdced2ebaa@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:RmJpyEjiXuRqUmgaZm1QBwTga24/jmX/fRRmDFOqxMC+URIG4Mo
 9gX0TIukctaeHtEikzQVN75R0XCXAhebe3xnGDc861FgSmYhuTZhRtUcv6LfThh5ZGluZKM
 OwQCEZ81VhqonW1JUWhx4UnRpTG6iEUnDBLNdX1VbF7o7UVX/F4L04rQRlbZmZVO8nhdUwv
 IFPNK3FZR/CTiUGOE/ALQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:G146lV2bwxw=:Wxg/zCL0otOkMi3TtpuduI
 rofKbkPhLxpBbsDDQ6GlLkGW7+pA3h2Vv97xwU7J4NdH4e9T2TVkJ22Y++zAWeB0XtnmaVFGO
 zD0txMvoqPJ2TdKddUVI2DmIMcgzdVe6BRLDM+HsGvTKmSGVSAKX1YtZte1roEgI9FZfP3HE2
 y00LKdqZwGcxwANcjKDHWtFnUrFHP76UVMu+3cygfW/fUYlszen5Cg8TI5It5ekIDkTr9/F9T
 ypt3fGUVCIxhsJnrLGquHVtAfOGgoJ8dfALDU0biRF567qNojgOXLaccAwKSBWIkMdxJyG3Iv
 3B33k8IdgoPwcWf7Q6H8jYcbjri6Sz1GidXQzd8rsmJE0NoiPa1Zcip7xYqc9pLJ1N72+pNkX
 Y3KckQUYTJkzvRoG7/TWGfV/SnruFkJ10JSR7yb73lo3uaqOp1F1Frd/GfCQblqb/ZQqI3Y6B
 2I0PGPaJUZJqUDPwWe6I412GBkOnT2J5Ad+XhermmDSn20zqbEgrvYx1R54b4cG+LwZx+wgWn
 Er90vgghy+SpyL7CojQpbMBgQiZD+umIo4Zs0LDhCr5O/dpC+O2yZlgzQGiP1ctTGkV29wpN7
 OABbvl5959Yuy8pVP8RJXPVJmq/s6zslgvhT+1IC/OnqjPdjFCPdM0J81gfBMSSm9MjN8cyb1
 4Jc8eSNzk9AVl+qh0Al+UzRRYqDOYcv7Yc18kdUyIklZy3cbmSmEtfv4byKC6vLooTjsb8XmI
 YpQ03pFNA4eJD1AHu95gH5+B/NVIqNoUd72WPGOMAfYNVwBNQMdbWV9N41o0p5Iae6wNcp04Q
 mmRBhHevqCDer6gjE2cFrKCeZslF3Z8lpNvM1iuu2KNcnXoEXo=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Omit an extra message for a memory allocation failure in this function.
>>
>> This issue was detected by using the Coccinelle software.
> 
> what exactly has the software detected?

Do you prefer the notification “WARNING: Possible unnecessary 'out of memory' message”
by the script “checkpatch.pl” instead?


> I cannot find, how this error is reported otherwise, it seems
> to me that the message is not that superflous.

Would you find the default allocation failure report sufficient?

Regards,
Markus