From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=113.46.200.220 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794907290; b=eKXNq4ViZWred5hqNe04MYQQzlI9567JSpT3CEHgc+Z72GBDx5OuiQ+Hqpa8yVA8iE50 JLFmddYLQS5OAJIPMN2HM9UxLQ7CQt0Suu9nVLF9po8YNsf/cEct6EFrwvZQPPv1ClYjV 4URtKIxvLeZqa3UscFvy5b8NuNtv/ulN5+ij17pIVU6+RZFkc6OcUYc/8abCzAO7HltsD zmj41zqU/iG8uDK0uJ67afNxhPEk1KekooNeuFfN5bsSP7goRKPtWJPHSGAThrJXUAhWu 3VTdo2qAdyb+j9+5nBOmNxwMq14pACHA3JvNgikZG3T+ygyp/GFjjpgbh4Oi2MNac2Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794907290; h=DMARC-Filter:dkim-signature:Received:Received:Received:Subject:To:CC: References:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: Content-Type:Content-Language:Content-Transfer-Encoding: X-Originating-IP:X-ClientProxiedBy; bh=NelY0F3SQaoHpZaa48RfVKojhT0mMWhbxVhRpg0tfCU=; b=c679xahtzOtq7ic7NR8Vrg2XS9DNDUXNEiD8mkSIulFBxZdCmKVJ21dUN9jnDhXWkJAk X2sWDEa2idpb4RVbnj2tYZJT6RDbL/yDfajBU1F5oSm8FF0K17jXoCLi0obkZ1YOSQ9EH 6fYTA4sm4kv2Eeu0c3TrvrEuqBuGR4BwzNjuRcX6ZGCtV2mtQNt/xD5KFUusqUWoxbxOY Ds3EGC6nV2Ljwk5yrcEEST5K1S/bHxJifpOXNwgh3BFzgKTiPTcgCDerRe0/SMjpkCTpD sqFXveJizunq/s5tzHqs+rwj9WLHVGnsz/9CyV/ALmHZj4HQob9cIjsWI7VAH3ovphg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=wcMqPt0Q; arc=none smtp.remote-ip=113.46.200.220 Received: from canpmsgout05.his.huawei.com (canpmsgout05.his.huawei.com [113.46.200.220]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF67606A339; Tue, 17 Nov 2026 09:21:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5FF67606A339 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=wcMqPt0Q dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=NelY0F3SQaoHpZaa48RfVKojhT0mMWhbxVhRpg0tfCU=; b=wcMqPt0QhszyRzva4g7wZmx964J1LB82GE/yeVL9LyN+DZ3q7eziWeveRgCFaAaPBdYeCBQiX 9FaWQ1vHk5u3RT5eFgJLnfpdsyXTk+FiUTHQg8fFnGbdIKoRqYmksHh6O0iFhakPsKKPB35Ps5S cmyonBF0d5EmEbjEKCpSmik= Received: from mail.maildlp.com (unknown [172.19.162.140]) by canpmsgout05.his.huawei.com (SkyGuard) with ESMTPS id 4jTK2j3ctZz12LD4; Tue, 17 Nov 2026 17:20:29 +0800 (CST) Received: from whupemk100004.china.huawei.com (unknown [7.152.185.74]) by mail.maildlp.com (Postfix) with ESMTPS id 503DB203AB; Tue, 17 Nov 2026 17:21:22 +0800 (CST) Received: from [10.173.125.21] (10.173.125.21) by whupemk100004.china.huawei.com (7.152.185.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 17 Nov 2026 17:21:18 +0800 Subject: Re: [PATCH v6 3/7] mm/memory-failure: add hwpoison_boot_page() to flag an inherited frame To: Breno Leitao CC: , , , , , , , , , , Ard Biesheuvel , Ilias Apalodimas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Naoya Horiguchi , Oscar Salvador , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Catalin Marinas , Will Deacon , Mark Rutland , , , Brendan Jackman , Johannes Weiner , Zi Yan , References: <20261016-hwpoison-kho-v6-0-f304255147da@debian.org> <20261016-hwpoison-kho-v6-3-f304255147da@debian.org> From: Miaohe Lin Message-ID: <869891e5-3f4f-e404-1068-53e6ff169805@huawei.com> Date: Tue, 17 Nov 2026 17:21:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 In-Reply-To: <20261016-hwpoison-kho-v6-3-f304255147da@debian.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems200001.china.huawei.com (7.221.188.67) To whupemk100004.china.huawei.com (7.152.185.74) On 2026/10/16 20:15, Breno Leitao wrote: > A kernel that kexecs inherits the frames its predecessor found > hardware-poisoned. It has to carry them as PG_hwpoison in its own memmap, > so that everything that already understands the flag covers them, > including the kexec segment placement check. > > Add a helper that sets the flag and counts the frame in > num_poisoned_pages. It runs while the memmap is initialised, before > memory_dev_init() has run. memblk_nr_poison_inc() divides by > sections_per_block, which memory_dev_init() sets, so the helper > increments num_poisoned_pages itself instead of calling > num_poisoned_pages_inc(). > > An inherited frame is a hardware failure like any other, so the helper > sets hw_memory_failure. Without it, unpoison_memory() accepts the frame, > clears the flag and drops the last reference, which frees a frame that > is still bad. > > The helper also counts the frame as managed, as a frame that fails at > run time stays counted. Memory offlining subtracts every frame of the > block that is not PageOffline, so a frame that was never counted leaves > the managed page count too low after an offline. > > The per-node memory failure statistics are not updated. This kernel > handled no failure, it only inherited one. > Thanks for your patches. :) Some questions below. > Signed-off-by: Breno Leitao > --- > mm/internal.h | 5 +++++ > mm/memory-failure.c | 8 ++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/mm/internal.h b/mm/internal.h > index da14c56fb24e11..4bd3bbce86e0ad 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1169,6 +1169,7 @@ void SetPageHWPoisonTakenOff(struct page *page); > void ClearPageHWPoisonTakenOff(struct page *page); > bool take_page_off_buddy(struct page *page); > bool put_page_back_buddy(struct page *page); > +void __init hwpoison_boot_page(struct page *page); > struct task_struct *task_early_kill(struct task_struct *tsk, int force_early); > void add_to_kill_ksm(struct task_struct *tsk, const struct page *p, > struct vm_area_struct *vma, struct list_head *to_kill, > @@ -1181,6 +1182,10 @@ static inline int unmap_poisoned_folio(struct folio *folio, unsigned long pfn, b > { > return -EBUSY; > } > + > +static inline void hwpoison_boot_page(struct page *page) > +{ > +} > #endif > > extern unsigned long __must_check vm_mmap_pgoff(struct file *, unsigned long, > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index a2ca8df501caee..d0d6b184ee469f 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -96,6 +96,14 @@ void num_poisoned_pages_sub(unsigned long pfn, long i) > memblk_nr_poison_sub(pfn, i); > } > > +void __init hwpoison_boot_page(struct page *page) Should we add some debug aids to let users know the origin of these hwpoisoned pages? > +{ > + SetPageHWPoison(page); Should we try to hold an extra page refcnt, as memory_failure does? > + atomic_long_inc(&num_poisoned_pages); > + hw_memory_failure = true; > + adjust_managed_page_count(page, 1); Is what adjust_managed_page_count does inconsistent with what the hwpoison_boot_page function describes? Should it be factored out? Also, is adjust_managed_page_count time-consuming? Should we consider batching the calls to reduce the impact on system boot latency? Maybe I'm overthinking it... Thanks. .