From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=35.157.23.187 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795020436; b=op23ElYXY+ekkAdphne71+Y5qf7xvk9NQd7VqJgMbEbqRf1gJEQ25Mz20+LD7JCzdBXB LsCkIao90h+OTsAgRSdSO05lwiKwHwGsVzuD/BS4r5NfFEYG+5LkvlkruKln1FFOrtgyA ieZLUA8sXOgjpKfWQlGO6On7nxWf5IJmi0zojuau4RZNdoHm2y1qxE4uktgX5BUNwmRAA HHNSPmmUTvKpnYr56M0WSrSqVl9dcuaByubDc9e/nnqRS7IOVzuSMqQkCHkm1jBXFSLK8 birQIBv8iDAb4KZ9i276NjQuGgG9Bmb6M7a3YV7ljwy0FlzehPVGhTbty3h3uNYGjGA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795020436; h=DMARC-Filter:Received:Received:DKIM-Signature:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:CC:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; bh=m7HJPKZjOaKBrKE2FvJlU85AYyo3fRGYNdlW0jrYWVM=; b=I2CnCsZ2/avGsSMHhZgM/S9/VNEuz4P3sDk1CL2TYKYzHdTvqrr5HTgUr3Clzp3C2qAb zP6qdT9BuLEZS5/OOJXAqgBNxcJw+LalEUeP+7yHuVoGWph8UBwvYGMP5dcC1t1x50iaA Se1Mt793RVKgVIQ89UrM+h4wnAbMN2wRuyGqBel34c9s2AatE2Lg7xsOL+wCgKNpbkhRn 7rdp4XevvqFFSGHUllQe7OGFBjdurkSpt2iU7tWfRHliZyWUSwmdGPHTvFcpT3MXoaKGo FDwbsORLY7PBjFJ0dO24xJ7uTNSoCh0Ff4pycmQ57GaW1QpCe4ZwOyp0YIotNKT3AiQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=paragon-software.com; spf=pass smtp.mailfrom=paragon-software.com; dkim=pass header.d=paragon-software.com header.i=@paragon-software.com header.a=rsa-sha256 header.s=mail header.b=TNEZDqRA; arc=none smtp.remote-ip=35.157.23.187 Received: from relayaws-01.paragon-software.com (relayaws-01.paragon-software.com [35.157.23.187]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1C4D606A320; Wed, 18 Nov 2026 16:47:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C1C4D606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=paragon-software.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paragon-software.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=paragon-software.com header.i=@paragon-software.com header.a=rsa-sha256 header.s=mail header.b=TNEZDqRA Received: from relayfre-01.paragon-software.com (relayfre-01.paragon-software.com [176.12.100.13]) by relayaws-01.paragon-software.com (Postfix) with ESMTPS id 409BE1D38; Wed, 18 Nov 2026 16:47:51 +0000 (UTC) Authentication-Results: relayaws-01.paragon-software.com; dkim=pass (1024-bit key; unprotected) header.d=paragon-software.com header.i=@paragon-software.com header.b=TNEZDqRA; dkim-atps=neutral Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relayfre-01.paragon-software.com (Postfix) with ESMTPS id C86CE217F; Wed, 18 Nov 2026 16:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1795020427; bh=m7HJPKZjOaKBrKE2FvJlU85AYyo3fRGYNdlW0jrYWVM=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=TNEZDqRANCiCAcKHl5I+BGAVQrD0DQQhNFLkpSapLGxvvlOJiX3XXpoQgzZQilvAv EyTrDv3EnnU4Heagz4li9Pk+CQVz85i895TtHkt4bcGe3YR9OKwHI5dY/IyVr2jdrx bFJFlSvvCtwZ1OFYXXO14tXo6eWrmK1v5IMUZd7c= Received: from [192.168.95.128] (172.30.20.220) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 18 Nov 2026 19:47:06 +0300 Message-ID: <869e98bb-1650-4b7e-9bd1-f7d60fac0a78@paragon-software.com> Date: Wed, 18 Nov 2026 17:47:04 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ntfs3: add permission checks for NTFS system attributes To: Hongling Zeng CC: , , , References: <20260820085526.169144-1-zenghongling@kylinos.cn> Content-Language: en-US From: Konstantin Komarov In-Reply-To: <20260820085526.169144-1-zenghongling@kylinos.cn> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: vobn-exch-01.paragon-software.com (172.30.72.13) To vdlg-exch-02.paragon-software.com (172.30.1.105) On 8/20/26 10:55, Hongling Zeng wrote: > ntfs3_setxattr() allows system.dos_attrib, system.ntfs_attrib, and > system.ntfs_attrib_be to update NTFS file attributes without permission > checks. These attributes affect the inode mode because the READONLY flag > is mapped to write permission bits, allowing unprivileged users to bypass > file access controls. > > system.ntfs_security allows modifying NTFS security descriptors which > control access control. Similar to POSIX ACLs where file owners can > modify access permissions, require inode owner or CAP_FOWNER for these > NTFS system attributes. > > Fixes: 4534a70b7056 ("fs/ntfs3: Add headers and misc files") > Cc: stable@vger.kernel.org > Signed-off-by: Hongling Zeng > --- > fs/ntfs3/xattr.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c > index 7a81369a1173..4e41aca0d5c7 100644 > --- a/fs/ntfs3/xattr.c > +++ b/fs/ntfs3/xattr.c > @@ -868,6 +868,22 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler, > struct ntfs_inode *ni = ntfs_i(inode); > enum FILE_ATTRIBUTE new_fa; > > + /* > + * system.dos_attrib and system.ntfs_attrib affect file permissions > + * because the READONLY flag is mapped to write permission bits. > + * system.ntfs_security controls NTFS security descriptors. > + * > + * Require the caller to own the inode or hold CAP_FOWNER before allowing > + * these NTFS system attributes to be changed. > + */ > + if (!strcmp(name, SYSTEM_DOS_ATTRIB) || > + !strcmp(name, SYSTEM_NTFS_ATTRIB) || > + !strcmp(name, SYSTEM_NTFS_ATTRIB_BE) || > + !strcmp(name, SYSTEM_NTFS_SECURITY)) { > + if (!inode_owner_or_capable(idmap, inode)) > + return -EPERM; > + } > + > /* Dispatch request. */ > if (!strcmp(name, SYSTEM_DOS_ATTRIB)) { > if (sizeof(u8) != size) Hello, Your patch is applied, thank you. Regards, Konstantin