From: Nguyen Dinh-R00091 <R00091@freescale.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: <linux-kernel@vger.kernel.org>, <amit.kucheria@canonical.com>,
<linux@arm.linux.org.uk>, <s.hauer@pengutronix.de>,
<grant.likely@secretlab.ca>,
<linux-arm-kernel@lists.infradead.org>, <daniel@caiaq.de>,
<u.kleine-koenig@pengutronix.de>,
Zhang Lily-R58066 <R58066@freescale.com>,
<valentin.longchamp@epfl.ch>
Subject: RE: [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions.
Date: Thu, 4 Nov 2010 12:21:33 -0700 [thread overview]
Message-ID: <86A0E76937111F4C92FABEC0A20988510523CEC2@az33exm21> (raw)
In-Reply-To: <4CD12833.8060204@eukrea.com>
Hi Eric,
>-----Original Message-----
>From: Eric Bénard [mailto:eric@eukrea.com]
>Sent: Wednesday, November 03, 2010 4:16 AM
>To: Nguyen Dinh-R00091
>Cc: linux-kernel@vger.kernel.org; amit.kucheria@canonical.com; linux@arm.linux.org.uk;
>s.hauer@pengutronix.de; grant.likely@secretlab.ca; linux-arm-kernel@lists.infradead.org;
>daniel@caiaq.de; u.kleine-koenig@pengutronix.de; Zhang Lily-R58066; valentin.longchamp@epfl.ch
>Subject: Re: [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions.
>
>Hi Dinh,
>
>Le 02/11/2010 23:17, Dinh.Nguyen@freescale.com a écrit :
>> From: Dinh Nguyen<Dinh.Nguyen@freescale.com>
>>
>> Add mx53 support to cpu.c and mm.c.
>>
>> Signed-off by: Dinh Nguyen<Dinh.Nguyen@freescale.com>
>> static void query_silicon_parameter(void)
>> {
>> - void __iomem *rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
>> + void __iomem *rom;
>> u32 rev;
>>
>> + if (cpu_is_mx51())
>> + rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
>> + else if (cpu_is_mx53())
>> + rom = ioremap(MX53_IROM_BASE_ADDR, MX53_IROM_SIZE);
>> +
>isn't the correct way to get the silicon revision to read the "Product
>Revision register" and "Silicon Revision register" of the IIM and not from the
>internal ROM ? (page 41-11 of the i.MX51 reference manual).
>
>Eric
Reading the ROM code is probably the most reliable way to get the correct silicon revision. Because the ROM that is on the chip is "most likely" up-to-date with the silicon. "Most likely" means that 95% of the time, when you get a new silicon, the ROM code will get updated. There is still a chance that a new silicon will not require a ROM update.
Also the other reason is that sometimes the fuses that identify the silicon revision that are used by the IIM are sometimes not blown to reflect the correct revision in pre-production parts. MX51 is a post production part, so in theory, the fuses are blown correctly. But since we made MX51 boards available prior to going into production, reading from the IIM is not as reliable as reading the ROM.
Thanks,
Dinh
next prev parent reply other threads:[~2010-11-04 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 22:17 [PATCH 1/2] ARM: imx: Add core definitions for MX53 Dinh.Nguyen
2010-11-02 22:17 ` [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions Dinh.Nguyen
2010-11-02 22:21 ` Russell King - ARM Linux
2010-11-03 9:15 ` Eric Bénard
2010-11-04 19:21 ` Nguyen Dinh-R00091 [this message]
2010-11-04 20:30 ` Eric Bénard
2010-11-04 21:24 ` Nguyen Dinh-R00091
2010-11-04 21:30 ` Nguyen Dinh-R00091
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86A0E76937111F4C92FABEC0A20988510523CEC2@az33exm21 \
--to=r00091@freescale.com \
--cc=R58066@freescale.com \
--cc=amit.kucheria@canonical.com \
--cc=daniel@caiaq.de \
--cc=eric@eukrea.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®