From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC7113126C0 for ; Fri, 24 Jul 2026 11:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892580; cv=none; b=umWboPbJDhlN/VbFAdEB4b9FNlBHcX0XEbrFq7afhx/vdISinONZaJ+rf7PUlJvesmbAmRbb7I0k1MHlujeBI3O0Qe7qfEEQF7UaK/Lw7pYV9oZ+2d0Al6YjGbnm6Kjxr+cmf95yq5durSsf5nB2wlDoiXD4XEiB6UcVmnA9Sts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892580; c=relaxed/simple; bh=HIyN1NdmGCer9F+yJu2grC3funOToANcEOLvbt4tRHg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XxwhgJHCHkj9jGDAqKuCjU3Fyr784anYLvHe+GdXutiiw/Q+SkWpI2/6sQu9rRwd0X/kyVTXVxKW1fyI1em/iYEwfiVA5nJJYjm+l3s94pPvLlrzDOBDxR+6IhvCTVmHYl0DSiQiXbrHapfvOHWI3+Yv93RuHs8FSRpjxXjKMPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Vyzx2B1m; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+3RUqOA1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GWz5iWSB; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=THxWSprj; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Vyzx2B1m"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+3RUqOA1"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GWz5iWSB"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="THxWSprj" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C41B77B708; Fri, 24 Jul 2026 11:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784892575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=52+ZZoUqNoPRpoXHSCU1buMvyDE9lTvYeytItMN1vSA=; b=Vyzx2B1m5VG4pvwjNDyHYpXp3HLNdXh2CiReVK9ETNxqsjoxCWQ+JRWshJfZ7bJCDeTk9O 4hG4jfH0QrHrOE+Ubdaj1e/c/27NgC0tNBqE2M+EU5n9LY67PKnHii0kpDVsHr02bDaXmj 8JII7ALqBNGJ6G3V5DdkxInF48O0uGQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784892575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=52+ZZoUqNoPRpoXHSCU1buMvyDE9lTvYeytItMN1vSA=; b=+3RUqOA12aH3EdCHQoNRuLeC0ACh+RpEZ9QldoVMMaZd18a1UaiFxRACKedRpqracDaTwy flF4cyXnau09HNDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=GWz5iWSB; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=THxWSprj DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784892573; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=52+ZZoUqNoPRpoXHSCU1buMvyDE9lTvYeytItMN1vSA=; b=GWz5iWSB/SE05vJWCEJ37yE0c4TKkXHKXOotQLeos4aH0Gj9B46BnvubAdDRSaY44BjfoT vQ8lUH/p6omgqgFXzGV98P1v6/66kLLkB0DBfqTFim+kPMPVunWv6MvgiuevllZBreRw/8 K10e1fYZcx+/aqIk+uCKQXThWxck5So= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784892573; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=52+ZZoUqNoPRpoXHSCU1buMvyDE9lTvYeytItMN1vSA=; b=THxWSprjgI1hs3CYrhhJBlEOmu0ZEB2Y4sUOL1IMLO5BA6/2FJBTUJbb50VV+wzmY01+Ta xpkhsra+60FDFGCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A4E82779BA; Fri, 24 Jul 2026 11:29:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gB/SJp1MY2pXLQAAD6G6ig (envelope-from ); Fri, 24 Jul 2026 11:29:33 +0000 Message-ID: <86a34ec5-ec73-45e8-997f-c7926e235d4d@suse.de> Date: Fri, 24 Jul 2026 13:29:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/udl: Use iosys_map getter for virtual address To: oushixiong1025@163.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou References: <20260724093808.776138-1-oushixiong1025@163.com> <20260724093808.776138-2-oushixiong1025@163.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260724093808.776138-2-oushixiong1025@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_TO(0.00)[163.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[163.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,kylinos.cn:email,suse.com:url,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; URIBL_BLOCKED(0.00)[suse.com:url,suse.de:mid,suse.de:dkim,kylinos.cn:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Queue-Id: C41B77B708 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action Hi Am 24.07.26 um 11:38 schrieb oushixiong1025@163.com: > From: Shixiong Ou > > Replace direct access to map->vaddr with the new iosys_map_get_vaddr() > helper function. This properly uses the iosys_map abstraction layer > instead of directly accessing structure members. > > Signed-off-by: Shixiong Ou > --- > drivers/gpu/drm/udl/udl_modeset.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c > index 289711035b67..06a3a4d149b9 100644 > --- a/drivers/gpu/drm/udl/udl_modeset.c > +++ b/drivers/gpu/drm/udl/udl_modeset.c > @@ -207,12 +207,16 @@ static int udl_handle_damage(struct drm_framebuffer *fb, > { > struct drm_device *dev = fb->dev; > struct udl_device *udl = to_udl(dev); > - void *vaddr = map->vaddr; /* TODO: Use mapping abstraction properly */ > + void *vaddr; > int i, ret; > char *cmd; > struct urb *urb; > int log_bpp; > > + vaddr = iosys_map_get_vaddr(map); > + if (!vaddr) > + return -EFAULT; > + This doesn't work in practice because we don't handle the vmap_iomem correctly. You'll get NULL now, when before it was treated as a regular address. The current type aliasing works until we have proper import handling of I/O-mem addresses. Best regards Thomas > ret = udl_log_cpp(fb->format->cpp[0]); > if (ret < 0) > return ret; -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)