Re: [PATCH] ASoC: mediatek: mt8188-mt6359: select CONFIG_SND_SOC_MT6359_ACCDET

["Arnd Bergmann" <arnd@arndb.de>]

On Wed, May 7, 2025, at 18:41, Nícolas F. R. A. Prado wrote:
> On Mon, May 05, 2025 at 07:20:52AM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> The driver support was added without selecting the codec, which leads to
>> a link failure:
>> 
>> aarch64-linux-ld: sound/soc/mediatek/mt8188/mt8188-mt6359.o: in function `mt8188_mt6359_init':
>> mt8188-mt6359.c:(.text+0x19f0): undefined reference to `mt6359_accdet_enable_jack_detect'
>
> Hm, I cannot seem to reproduce this. I just tried to build on today's next with
> CONFIG_SND_SOC_MT6359_ACCDET disabled and have tried
> CONFIG_SND_SOC_MT8188_MT6359 both =m and =y, but in both cases it compiles fine.

The config that failed for me had CONFIG_SND_SOC_MT6359_ACCDET.

> I wonder if somehow your tree was missing "ASoC: mediatek: mt6359: Add stub for
> mt6359_accdet_enable_jack_detect" [1]

> https://lore.kernel.org/all/20250306-mt8188-accdet-v3-3-7828e835ff4b@collabora.com/

I had not seen that patch, but with that applied, my patch needs to
be revised as well. If the idea is that CONFIG_SND_SOC_MT8188_MT6359
can work correctly without CONFIG_SND_SOC_MT6359_ACCDET, it should be

      depends on SND_SOC_MT6359_ACCDET || !SND_SOC_MT6359_ACCDET

in order to force SND_SOC_MT8188_MT6359=m if the ACCDET portion
is in a loadable module.

If SND_SOC_MT8188_MT6359 requires SND_SOC_MT6359_ACCDET to work
correctly, then my original patch is still needed and yours
should be reverted.

     Arnd