From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792922382; b=BbxYCbhzFtC80yH5fJmuaTcpfPOp4zS13Nv4GPPAHX/P5UCQyHujJd8vt+wT3NPgT5T7 aQikCRwQAx1vZDNlpR9uoOp7okJYdnA7Z/mvfiTalB1AF6WdNq16oHsfJF0eU5sS+wUTU AJEixF1ajWHcMEs/GoePm8TOMJQCe/aUYZGa0GDkaRl26ckIOTQiayIcwCtR4ZLkbpIrH ui00qxXVXRnG2GWByYbeWp1iIE+plgqrcKO0TLWKm00WeyoRcZBCREdEHInWmD7kRFPcA riTZAP98HP/JFsMfrZJMTJnSxKCTdrlJVhaYFi0CgAmmtzA0cpB3BdyLChXUcKVl4GA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792922382; h=Received:DKIM-Signature:Received:Date:Message-ID:From:To:Cc:Subject: In-Reply-To:References:User-Agent:MIME-Version:Content-Type: X-SA-Exim-Connect-IP:X-SA-Exim-Rcpt-To:X-SA-Exim-Mail-From: X-SA-Exim-Scanned; bh=xIQqI/QjyZL4p06+WdD3fxaMN1wfhh85wLBF3MVo7TE=; b=VbFNAkOB8voMeVRQ0rGQGvA3rvxT+m45eKLJITAMqvsdP/fbGIDPQrtcyJmW6DDboHxw h2odSgGsx8kSsruxbKpHhTvzVm1Apcj2oi8yNfieE7gJQAeBgu7m0G6wPBMh7ksfrwucj ZeOc3QBJdQfSJw2AYEYwTQWlRu2RB1qFptNq9BUfSE/NanS0k2YDNEMC6MBiUpZttRwHP oD+dBNslEstO4wLDO21+RrR6mqgrd153MN5P4zGVQttgD9hhIJymJ8/mLSzTOhj+GrsOH YmnxDp+7kM6FMTNarK+88W7QrgOwvpnK/ID4hvmD6g/iHEOwQg73pxbfJR3PZGmx3dQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YHelLjlJ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 237E0606A31B; Sun, 25 Oct 2026 09:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YHelLjlJ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 963631F01825; Sun, 25 Oct 2026 09:59:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792922381; bh=xIQqI/QjyZL4p06+WdD3fxaMN1wfhh85wLBF3MVo7TE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=YHelLjlJOUyt2KQNA0QZuzFedX4B3jR+xiUPlRQn2HpQxsFQIKVZ9DhW5qYi3xIx8 a2Qr4wDR3dbT7aPbzk+E1edyGAW6YJ05jaoWaheuOwSmZyHtE1ilf/mx4PmKeeWs96 TIPfhmRazGKTWUrroCBOqbkQZez8JUyiikAtOV4IA0L0jJkrQD/G9kKEn5mmPbnT+i hQe2fjvpoNYEynim4BcIxOr7rkkGoQzUCKwWbmfLg+vVo78JlCpCi+uKurGpUxIxYN g7kpgYyK9t+rWWbhzlrCPECmSmkO+b6RUAhQSEh7NaLjj2brTOH7hRT+/hcfDEfcHp JZcIzT4qED8Uw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xKv0s-00000006w0l-3p5c; Sun, 25 Oct 2026 09:59:39 +0000 Date: Sun, 25 Oct 2026 09:59:38 +0000 Message-ID: <86a4o2yub9.wl-maz@kernel.org> From: Marc Zyngier To: Janne Grunau Cc: Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2ls?= =?UTF-8?B?Y3p5xYRza2k=?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Luca Ceresoli , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] PCI: apple: Avoid PERST# deassertion through gpiod initialization In-Reply-To: <20261024-pcie-apple-perst-gpiod-init-v1-1-f92f30f205ef@jannau.net> References: <20261024-pcie-apple-perst-gpiod-init-v1-1-f92f30f205ef@jannau.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: j@jannau.net, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, luca.ceresoli@bootlin.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 24 Oct 2026 17:46:54 +0100, Janne Grunau wrote: > > Commit 87620512681a ("PCI: apple: Fix PERST# polarity") switched the > PERST# polarity by annotaing its GPIO as active low in the device tree > via [1]. It missed to update gpiod_get()'s flags to GPIOD_OUT_HIGH > resulting in deasserting PERST# through gpiod initialization. > The Aquantia AQC113 10GB ethernet device used in some Apple silicon > desktop does not finish link training with this additional PERST# > deassert before the usual PERST# dance. > > Link: https://lore.kernel.org/linux-pci/20211123180636.80558-1-maz@kernel.org/ [1] > Fixes: 87620512681a ("PCI: apple: Fix PERST# polarity") > Cc: stable@vger.kernel.org > Signed-off-by: Janne Grunau > --- > This issue affects only a single PCIe devices of the handful of built-in > devices integrated in Apple silicon devices. It is usually hidden by > u-boot's initialisation of PCIe devices. > --- > drivers/pci/controller/pcie-apple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > index c2cffc0659f4..a7f327803060 100644 > --- a/drivers/pci/controller/pcie-apple.c > +++ b/drivers/pci/controller/pcie-apple.c > @@ -562,7 +562,7 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > int ret, i; > > reset = devm_fwnode_gpiod_get(pcie->dev, of_fwnode_handle(np), "reset", > - GPIOD_OUT_LOW, "PERST#"); > + GPIOD_OUT_HIGH, "PERST#"); > if (IS_ERR(reset)) > return PTR_ERR(reset); > > Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.