From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753022AbcGTHRf (ORCPT ); Wed, 20 Jul 2016 03:17:35 -0400 Received: from icp-osb-irony-out9.external.iinet.net.au ([203.59.1.226]:10056 "EHLO icp-osb-irony-out9.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbcGTHRd (ORCPT ); Wed, 20 Jul 2016 03:17:33 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AEBgA6JI9X/zXSMGcNUBwBAYQhUqN2AQEBAQEBBpJdhAmGGgKBfwEBAQEBAYVpAQEBAQIBI1YFCwsNCwICJgICVwYBDAYCAQGIJK5rZ412AQEBAQEBAQEBAQEBAQEBASGBAYRhgkCCVYdBgloFmSUBmEqFUEiPWIRZXIdwAQEB X-IPAS-Result: A2AEBgA6JI9X/zXSMGcNUBwBAYQhUqN2AQEBAQEBBpJdhAmGGgKBfwEBAQEBAYVpAQEBAQIBI1YFCwsNCwICJgICVwYBDAYCAQGIJK5rZ412AQEBAQEBAQEBAQEBAQEBASGBAYRhgkCCVYdBgloFmSUBmEqFUEiPWIRZXIdwAQEB X-IronPort-AV: E=Sophos;i="5.28,393,1464624000"; d="scan'208";a="58251598" Subject: Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups To: Geert Uytterhoeven , Nicolas Pitre References: <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> <1468812716-30537-2-git-send-email-nicolas.pitre@linaro.org> Cc: Linux FS Devel , "linux-kernel@vger.kernel.org" , Alexander Viro , David Howells From: Greg Ungerer Message-ID: <86a6d195-d63a-ecb3-e17d-4d1da2d2a739@linux-m68k.org> Date: Wed, 20 Jul 2016 17:18:29 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 20/07/16 16:54, Geert Uytterhoeven wrote: > Hi Nicolas, > > On Wed, Jul 20, 2016 at 6:09 AM, Nicolas Pitre wrote: >> On Tue, 19 Jul 2016, Geert Uytterhoeven wrote: >> >>> On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer wrote: >>>> Seeing as you have modified quite a few printk calls is it worth >>>> while annotating them with appropriate KERN_ERR, KERN_INFO, etc? >>> >>> You mean pr_err(), pr_info(), ... ;-) >> >> Done. Included in v3. > > Really? The only change in v3 is the Reviewed-by? Patch 2 in the series now does this: [PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form Regards Greg > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >