From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "zhiyong.tao" <zhiyong.tao@mediatek.com>,
lee.jones@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com,
lgirdwood@gmail.com, broonie@kernel.org,
eddie.huang@mediatek.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, fshao@chromium.org
Cc: sen.chu@mediatek.com, hui.liu@mediatek.com,
allen-kh.cheng@mediatek.com, hsin-hsiung.wang@mediatek.com,
sean.wang@mediatek.com, macpaul.lin@mediatek.com,
wen.su@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
zhiyong tao <zhiyong.tao@mediatk.com>
Subject: Re: [PATCH v2] pmic: add mt6366 regulator document
Date: Thu, 11 Aug 2022 11:58:10 +0300 [thread overview]
Message-ID: <86ab77f5-8beb-7237-d6e2-734f52ca176b@linaro.org> (raw)
In-Reply-To: <111e1073e1ce689e289e52c645a1be2e7dc7fe12.camel@mediatek.com>
On 11/08/2022 11:42, zhiyong.tao wrote:
>>
>>>
>>> Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com>
>>> ---
>>> .../regulator/mediatek,mt6366-regulator.yaml | 375
>>> ++++++++++++++++++
>>> 1 file changed, 375 insertions(+)
>>
>> Subject does not match subsystem.
>
> Hi Krzysztof,
>
> Do you mean that we should change the title like this:
> regulator: dt-bindings: mediatek: add mt6366 regulator document
> is it right?
Yes. And remove redundant pieces so for example:
regulator: dt-bindings: mediatek: add mt6366
or:
regulator: dt-bindings: add mediatek,mt6366
(...)
>>> + patternProperties:
>>> + "^buck-
>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$":
>>> + type: object
>>> + $ref: "regulator.yaml#"
>>
>> No need for quotes.
> ==>
> We will remove the line "$ref: "regulator.yaml#"" in next verison, is
> it right?
No, it is not. Why do you want to remove it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-11 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 6:27 [PATCH v2 0/1] Mediatek MT6366 Regulator patch Zhiyong Tao
2022-07-28 6:27 ` [PATCH v2] pmic: add mt6366 regulator document Zhiyong Tao
2022-07-28 10:46 ` Krzysztof Kozlowski
2022-08-03 9:50 ` Rex-BC Chen
2022-08-04 2:31 ` Chen-Yu Tsai
2022-08-04 7:25 ` Krzysztof Kozlowski
[not found] ` <111e1073e1ce689e289e52c645a1be2e7dc7fe12.camel@mediatek.com>
2022-08-11 8:58 ` Krzysztof Kozlowski [this message]
[not found] ` <3d120fdb5d26d1211f797e5a26e8af3f34439424.camel@mediatek.com>
2022-08-11 9:15 ` Krzysztof Kozlowski
2022-07-28 11:07 ` Mark Brown
[not found] ` <9a99a1e95179f3b55dd1236c41a8cd3d9b2ccf18.camel@mediatek.com>
2022-08-01 11:14 ` Mark Brown
2022-07-28 10:59 ` [PATCH v2 0/1] Mediatek MT6366 Regulator patch Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ab77f5-8beb-7237-d6e2-734f52ca176b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=fshao@chromium.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sen.chu@mediatek.com \
--cc=wen.su@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
--cc=zhiyong.tao@mediatk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®