From: Andrew Lunn <andrew@lunn.ch>
To: Moon Yeounsu <yyyynoom@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show`
Date: Mon, 7 Apr 2025 22:48:01 +0200 [thread overview]
Message-ID: <86ac7c66-66da-458f-960a-3b27ba5e893f@lunn.ch> (raw)
In-Reply-To: <20250407134930.124307-1-yyyynoom@gmail.com>
> Additionally, the previous code did not manage statistics
> in a structured manner, so this patch:
>
> 1. Added `u64` type stat counters to the `netdev_private` struct.
> 2. Defined a `dlink_stats` struct for managing statistics.
> 3. Registered standard statistics and driver-specific statistics
> separately.
> 4. Compressing repetitive tasks through loops.
>
> The code previously blocked by the `#ifdef MEM_MAPPING` preprocessor
> directive has been enabled. This section relates to RMON statistics and
> does not cause issues when activated. Removing unnecessary preprocessor
> directives simplifies the code path and makes it more intuitive.
When i see a list like this, it makes me think this should be broken
up into multiple patches. Ideally you want lots of simple patches
which are obviously correct.
Andrew
next prev parent reply other threads:[~2025-04-07 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 13:49 Moon Yeounsu
2025-04-07 20:43 ` Andrew Lunn
2025-04-07 22:12 ` Moon Yeounsu
2025-04-08 12:31 ` Andrew Lunn
2025-04-07 20:48 ` Andrew Lunn [this message]
2025-04-07 22:57 ` Moon Yeounsu
2025-04-08 12:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ac7c66-66da-458f-960a-3b27ba5e893f@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®