From: Guenter Roeck <linux@roeck-us.net>
To: Arthur Korn <akorn@google.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] hwmon: (pmbus/max16601) Support byte data writes on VSA rail
Date: Fri, 20 Nov 2026 11:28:02 -0800 [thread overview]
Message-ID: <86af448b-50da-406a-8ed3-7796dc9b7252@roeck-us.net> (raw)
In-Reply-To: <20261120024416.338876-1-akorn@google.com>
On Fri, Nov 20, 2026 at 02:44:15AM +0000, Arthur Korn wrote:
> MAX16601 exposes the secondary VSA rail on virtual PMBus page 2 backed
> by a separate I2C client (data->vsa), while page 1 is a read-only
> virtual page for VCORE input current and power telemetry. Although the
> driver routes byte reads on page 2 to data->vsa via max16601_read_byte()
> and PMBUS_CLEAR_FAULTS byte writes via max16601_write_byte(), it does
> not implement write_byte_data(), and max16601_write_byte() falls through
> to -ENODATA on virtual page 1.
>
> As a result, PMBus 1.2+ byte-data status writes from pmbus_core (such as
> clearing individual status bits in pmbus_get_boolean() or clearing
> STATUS_CML faults during probe) on page 2 are sent to the primary VCORE
> client instead of data->vsa, and byte writes on virtual page 1 fall
> through to page 0.
>
> Implement max16601_write_byte_data() mirroring max16601_read_byte() to
> forward page 2 byte-data writes to data->vsa and reject virtual page 1
> with -EOPNOTSUPP, and reject virtual page 1 in max16601_write_byte() as
> well.
>
> Fixes: 2138f8853a00 ("hwmon: (pmbus) Driver for Maxim MAX16601")
> Signed-off-by: Arthur Korn <akorn@google.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2026-11-20 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 2:44 Arthur Korn
2026-11-20 2:44 ` [PATCH v3 2/2] hwmon: (pmbus) Clear only CML command and data faults during probe Arthur Korn
2026-11-20 19:28 ` Guenter Roeck
2026-11-20 19:28 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86af448b-50da-406a-8ed3-7796dc9b7252@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akorn@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®