From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbdG0NtU (ORCPT ); Thu, 27 Jul 2017 09:49:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbdG0NtT (ORCPT ); Thu, 27 Jul 2017 09:49:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 33890C013C51 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH v2] KVM: x86: Avoid guest page table walk when gpa_available is set To: Brijesh Singh , rkrcmar@redhat.com, joro@8bytes.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, Thomas.Lendacky@amd.com References: <1495206749-25393-1-git-send-email-brijesh.singh@amd.com> From: Paolo Bonzini Message-ID: <86b4e9e3-b594-4470-375e-10a2a3e6a4ea@redhat.com> Date: Thu, 27 Jul 2017 15:49:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1495206749-25393-1-git-send-email-brijesh.singh@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 27 Jul 2017 13:49:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/2017 17:12, Brijesh Singh wrote: > - vcpu_is_mmio_gpa(vcpu, addr, exception->address, write) && > (addr & ~PAGE_MASK) == (exception->address & ~PAGE_MASK)) { ^^^^^^^^^^^^^^^^^^ I think this should be vcpu->arch.gpa_val. Paolo > - gpa = exception->address; > - goto mmio; > - } > + gpa = vcpu->arch.gpa_val; > + ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write); > + } else { >