From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B7831BFE18 for ; Thu, 17 Oct 2024 15:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729177998; cv=none; b=W0cF9RUNYF4S4UnA3MlDM7OxKH+lRJfiC18DZqQW9K9IKE+S5OZ6cZzDfxwJ+31Focic40eLQ0FbCOYcyaSKwhK472xfdhl//X4mCy+w+iSUTuFQCN5XPLfAp6yhCAdEjfT3fbz6AtgDzeAP4Dk+sccFp8RwPGEgJceBi1kK+Sg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729177998; c=relaxed/simple; bh=bA6oDFyN7Sm1kmRlntZWjgMzk8bVcjnMBuGvs5SSRsY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=AKNc9X3Dc9IgBKvQ2JueZEEzgo3pgT83DNndGucF1bLBzXasC/9EBaw9gEGVYo5J7ijSJibZ09oSsoW+SH9EXFupUVozlbNwekluYidlduPHGDicJknbVVc5vTuBgc5KPGpmeFMiPYCrDlH5/3Db/o4ADY77gC5yiY/60/se+2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KGylX7fT; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KGylX7fT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729177996; x=1760713996; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=bA6oDFyN7Sm1kmRlntZWjgMzk8bVcjnMBuGvs5SSRsY=; b=KGylX7fTE5PI8JGV2iAQDOdjG4I4Ldpj9exLg6SZv+BJGMkCqaMMAoii HrI14xHxgWJwmDSQwIQb1vq4tbLq+nQm4IPVEtZVdYSRzbTWJIAKeK8b0 aZWMxksP6EtTHV4frzl4Sb0Vl9GknTUoAqmc0MAi4nF/S5Df9uNvrgkcf yY7yKPRPq8t7V9R2bMO5UyQKpdk3Ah1u20yO7wTTMLiGXpFXMaj4ip49s Jiqm3CYc5y5ZmOvnn5STGPpNSNvJrV3AUGwbIo+Ov4FsuypwD/de/EVCZ Rj6YKXOeUUxut7aUY3FTqVoRte4UDRXVadjYKT7GLnzVnM+rBr0JF2HEB g==; X-CSE-ConnectionGUID: s6OcHROcRymm7OzosQND7w== X-CSE-MsgGUID: Whc0rbaoRwO9H+YYGfP2Rw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="32351966" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="32351966" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 08:13:16 -0700 X-CSE-ConnectionGUID: z9VxX2YJTo6Dv6DCiF3WdA== X-CSE-MsgGUID: 2FBoITzLTYmIxrhCWNwiEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="83346391" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO [10.245.246.150]) ([10.245.246.150]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 08:13:13 -0700 Message-ID: <86b5c0275e43d825b13a71ee2875e8ec48b56578.camel@linux.intel.com> Subject: Re: [PATCH v2] locking/ww_mutex: Adjust to lockdep nest_lock requirements From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= To: Boqun Feng Cc: intel-xe@lists.freedesktop.org, Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Maarten Lankhorst , Christian =?ISO-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Thu, 17 Oct 2024 17:13:09 +0200 In-Reply-To: References: <20241009092031.6356-1-thomas.hellstrom@linux.intel.com> Autocrypt: addr=thomas.hellstrom@linux.intel.com; prefer-encrypt=mutual; keydata=mDMEZaWU6xYJKwYBBAHaRw8BAQdAj/We1UBCIrAm9H5t5Z7+elYJowdlhiYE8zUXgxcFz360SFRob21hcyBIZWxsc3Ryw7ZtIChJbnRlbCBMaW51eCBlbWFpbCkgPHRob21hcy5oZWxsc3Ryb21AbGludXguaW50ZWwuY29tPoiTBBMWCgA7FiEEbJFDO8NaBua8diGTuBaTVQrGBr8FAmWllOsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQuBaTVQrGBr/yQAD/Z1B+Kzy2JTuIy9LsKfC9FJmt1K/4qgaVeZMIKCAxf2UBAJhmZ5jmkDIf6YghfINZlYq6ixyWnOkWMuSLmELwOsgPuDgEZaWU6xIKKwYBBAGXVQEFAQEHQF9v/LNGegctctMWGHvmV/6oKOWWf/vd4MeqoSYTxVBTAwEIB4h4BBgWCgAgFiEEbJFDO8NaBua8diGTuBaTVQrGBr8FAmWllOsCGwwACgkQuBaTVQrGBr/P2QD9Gts6Ee91w3SzOelNjsus/DcCTBb3fRugJoqcfxjKU0gBAKIFVMvVUGbhlEi6EFTZmBZ0QIZEIzOOVfkaIgWelFEH Organization: Intel Sweden AB, Registration Number: 556189-6027 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2024-10-16 at 10:12 -0700, Boqun Feng wrote: > On Wed, Oct 16, 2024 at 08:17:50AM +0200, Thomas Hellstr=C3=B6m wrote: > [...] > > >=20 > > > So even though first_lock_dep_map is a fake lock, it has to have > > > the > > > same wait types as a real mutex. > >=20 > > Understood. > > >=20 > > > Does this make sense? > >=20 > > Yes it does. I'll update to a v3, and add a Tested-by: tag. Would > > you >=20 > I think you should send a v3 then after I test, I will send my > Tested-by. >=20 > > like a Co-developed-by: tag as well? >=20 > It's not a big change onto yours, but feel free to add it. It would probably have taken me considerable time to find that missing LD_WAIT_SLEEP, but I forgot to ask for your S-O-B so I sent the patch without. Perhaps can be added at commit time if needed. Thanks again, Thomas >=20 > Regards, > Boqun >=20 > >=20 > > Thanks, > > Thomas > >=20 > >=20 > [...]