From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: <linux-sh@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3] sh: avoid using IRQ0 on SH3/4
Date: Sun, 1 May 2022 21:09:24 +0300 [thread overview]
Message-ID: <86b6c752-0599-d878-bff4-7d3d7b84176a@omp.ru> (raw)
In-Reply-To: <525e7383-d26a-fe35-7005-e1dd9b57f76f@omp.ru>
On 5/1/22 8:58 PM, Sergey Shtylyov wrote:
[...]
>>>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
>>>> and even now, when IRQ0 is about to be returned by platfrom_get_irq(), you
>>>> see a big warning. The code supporting SH3/4 SoCs maps the IRQ #s starting
>>>> at 0 -- modify that code to start the IRQ #s from 16 instead.
>>>>
>>>> The patch should mostly affect the AP-SH4A-3A/AP-SH4AD-0A boards as they
>>>> indeed use IRQ0 for the SMSC911x compatible Ethernet chip...
>>>
>>> Maybe try getting it landed through Andrew Morton's tree?
>>
>> Hi. I'm alive and looking at it. If it needs to go in for this cycle I
>> will send a pull request for just this and anything else critical. Was
>
> Well, now using IRQ0 just causes a WARNing in platform_get_irq() -- I don't
> think fixing it is critical enough. Starting from 5.19-rc1 the SMSC91xx driver
> should stop working on the mentioned boards.
> But let me look at the SMSC driver itself, I haven't done this yet...
Looks like these boards were borked back in 2015 by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=965b2aa78fbcb831acf4f669f494da201f4bcace
It stopped accepting IRQ0 for no apparent reason. :-/
[...]
>> Rich
MBR, Sergey
next prev parent reply other threads:[~2022-05-01 18:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 18:46 Sergey Shtylyov
2022-04-27 19:24 ` Sergey Shtylyov
2022-04-29 14:24 ` John Paul Adrian Glaubitz
2022-04-29 14:39 ` Greg Kroah-Hartman
2022-04-29 17:16 ` Rich Felker
2022-05-01 17:58 ` Sergey Shtylyov
2022-05-01 18:09 ` Sergey Shtylyov [this message]
2022-04-30 10:30 ` Rob Landley
2022-05-01 10:19 ` John Paul Adrian Glaubitz
2022-05-02 8:37 ` Geert Uytterhoeven
2022-05-02 20:07 ` Rob Landley
2022-05-03 7:02 ` Geert Uytterhoeven
2022-05-03 19:46 ` Maciej W. Rozycki
2022-05-02 20:56 ` Sergey Shtylyov
2022-05-03 6:58 ` Geert Uytterhoeven
2022-05-03 19:33 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b6c752-0599-d878-bff4-7d3d7b84176a@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®