From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 502FCC433F5 for ; Fri, 28 Jan 2022 12:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348607AbiA1Mj4 (ORCPT ); Fri, 28 Jan 2022 07:39:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:55757 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348560AbiA1Mjy (ORCPT ); Fri, 28 Jan 2022 07:39:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643373593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XLdIy983W00HY23HijSjN7Dj8OaLX+kcdPFkbzmAAbQ=; b=VNPaYnQgfOgedBbULORcVXFcaErsb72/pHha23aKMZVvWc0HeVUIQ43cwBP1xQvyfq7v+1 axCXa7oJpo4MlVwKjEEIe98eHNTqAAOafRpGoXTNASVDUkNBbZNq4tONwRjNxZpHOpbOk9 KFj+fyz0gLFVG4L/Q5KMRc5mCbZx5oU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-299-QPbxzhJ0McmChJXD6fh1MA-1; Fri, 28 Jan 2022 07:39:50 -0500 X-MC-Unique: QPbxzhJ0McmChJXD6fh1MA-1 Received: by mail-ed1-f72.google.com with SMTP id b26-20020a056402139a00b004094fddbbdfso2995694edv.12 for ; Fri, 28 Jan 2022 04:39:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XLdIy983W00HY23HijSjN7Dj8OaLX+kcdPFkbzmAAbQ=; b=Np03DXNzi+Q7R0gMH1/i8z6rXltcfTW0jV9Wc3OR9VtNrPrH8lQxL9qOtCeAB4mmAQ RULn9vdEjo6Fkta/BEC4tP+JDJNaDeq2u3bRr28tztYJKezAjIAicYIjerYT5D7ofgql LvVArQROLw7gVzoYyelYVKQ9pVx+/kzWDDMW8CemB40pdckSIjQ/tB8et5jaVsK+XbVS n7nH5b9JcW0Ijrl9Hpwwm7tzPauP5mRsAEZTn7caNjixYmeT8eIMFEDIjr5IJVW+J90A RS5ESLQ7Qb//MhTAjSIGLtJ9uKuhIXVvuX/7OiGMR+u9X34K89GwYYIzEA+PALRfVGXm PdyA== X-Gm-Message-State: AOAM530oSAFdfU6ba1FbnOKb1o2H/iujRwONYjw/FGGgq04Wz+1nupIl vRZNwi9Uk9eAGnaHZSZWfeK2DZw6badHWsIOxpC30rTF1hbfbG6eshuzQS1nFaufo9bK+H5pZBD KZWB+eE0Y99zXdsy1wnWkN9+i X-Received: by 2002:aa7:d799:: with SMTP id s25mr7885087edq.272.1643373589390; Fri, 28 Jan 2022 04:39:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJx24fxwd87A17OyboBva44f+bn420kREB83IoTX6XY5R1S3dYOyCYPwMJDB+SRMkrWzyxZHfA== X-Received: by 2002:aa7:d799:: with SMTP id s25mr7885074edq.272.1643373589175; Fri, 28 Jan 2022 04:39:49 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id gj10sm5543335ejb.192.2022.01.28.04.39.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 04:39:48 -0800 (PST) Message-ID: <86b78fe0-7123-4534-6aaf-12bd30463665@redhat.com> Date: Fri, 28 Jan 2022 13:39:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 0/5] KVM: nVMX: Fix Windows 11 + WSL2 + Enlightened VMCS Content-Language: en-US To: Vitaly Kuznetsov Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Maxim Levitsky , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20220112170134.1904308-1-vkuznets@redhat.com> <87k0exktsx.fsf@redhat.com> From: Paolo Bonzini In-Reply-To: <87k0exktsx.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/18/22 15:22, Vitaly Kuznetsov wrote: > Vitaly Kuznetsov writes: > >> Changes since v2 [Sean]: >> - Tweak a comment in PATCH5. >> - Add Reviewed-by: tags to PATCHes 3 and 5. >> >> Original description: >> >> Windows 11 with enabled Hyper-V role doesn't boot on KVM when Enlightened >> VMCS interface is provided to it. The observed behavior doesn't conform to >> Hyper-V TLFS. In particular, I'm observing 'VMREAD' instructions trying to >> access field 0x4404 ("VM-exit interruption information"). TLFS, however, is >> very clear this should not be happening: >> >> "Any VMREAD or VMWRITE instructions while an enlightened VMCS is active is >> unsupported and can result in unexpected behavior." >> >> Microsoft confirms this is a bug in Hyper-V which is supposed to get fixed >> eventually. For the time being, implement a workaround in KVM allowing >> VMREAD instructions to read from the currently loaded Enlightened VMCS. >> >> Patches 1-2 are unrelated fixes to VMX feature MSR filtering when eVMCS is >> enabled. Patches 3 and 4 are preparatory changes, patch 5 implements the >> workaround. >> > > Paolo, > > would it be possible to pick this up for 5.17? Technically, this is a > "fix", even if the bug itself is not in KVM) Yes, it is. I have queued the patch, and feel free to send a 5.16 backport too. Paolo