From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=165.173.182.11 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1793818846; b=hICGVi7gGpNMBgnCiutQj4jixcjQ4NhOJ1CNqD4jRwDayi7GBWkXBFzXVGJRDqmr8ffl cZVnKmp5IikNwx4Z0jM/6CzVXdmnpWVOI66arex/MvqS2VxTb1UhBvgF9lHFL/ktErHcX tFME6l7wv/iXgIFvf+1MdJZGSgm8JtLLTMLPrB1PnjR/JigcuCPhSXesAnWaaLadD8oIS 6kXWuPcQLjpaCrOcFHM4uKSZGNqK199lQBpDi6OcLpQ5ZTNOUCypQ9U2Ec4sY+m3zMjiJ NtO3D7Z+35ciTism5P8kd6myF4r/tVreP6U0+86bUJXbJSPe9/Sq2VrnhhTtKAsC2hw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793818846; h=DMARC-Filter:DKIM-Signature:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=VzZMLJITLVDB0A5Z42maKwswLtuUp4zeciOTqXGQ8aA=; b=lH1T5Y6KtXq+iHWuEEr35UNorv/PGOaUjPVS4s7SB42Jrx6f1nYTP9yQo75Gsx5ZTbOl 5HlanMQ58y4jN+4DtUnNnsmIOl8pvlBqFLC8vrwZMy9ezAeVYyd7+wLO7d39gXCC0Z9Dy la2JJnT4Yusl9PJUNwm14wuOL7lYSs4VjaT8MAX9Rt3u+wZgJWb4oaqediuRdOX3aVUwL 08T5R92z0JOEc1T4Kua3nQHsgjabppHNx8CHj0V028ZhgutAnWX904IybtQ2pTw+hIhWT maGhEtpj8Y66OfDVObRrrE3nY4wS9H5bnCvroD/Akcg2TleCwz6JLRsWOnFp3Pj94OA== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=zohomail header.b=dOrhpNMv; arc=pass header.oldest-pass=0 smtp.remote-ip=165.173.182.11 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B18B7606A32E; Wed, 4 Nov 2026 19:00:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B18B7606A32E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=zohomail header.b=dOrhpNMv ARC-Seal: i=1; a=rsa-sha256; t=1793818793; cv=none; d=zohomail.com; s=zohoarc; b=J5Nk2Imxaf8oS1qWOaYZ/5p36mXDAYuXtOJxtp/dopGz+YZql+vQvYrpX8mB7IauHA4Xk8YQi1qu+PaPR6mB24yVfAOhT6/bxucXIyTgAr5kbwboEEEoK0r/KXXOvBMiOSZV7ITsCmtFClDMxvvdkx5UHygUVxFFFyU3jHRL1IQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1793818793; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=VzZMLJITLVDB0A5Z42maKwswLtuUp4zeciOTqXGQ8aA=; b=IIHGp0XFAy4EBAI1xAOPiJGJtjBnAKa1DW4/mE+dskb/wg6rrm+SQ1O2NbrAIvdInYgZaN69e6gP4ugz8c37N7g/budnSoj0+vfCaDRddEsiHdsgyTHEUdlWXBny9WMxT0bGPo7exVlXSK9F2A5uzCRCit861dBAtMweU4FMdr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: a=rsa-sha256; b=dOrhpNMv1PBqHvf04rmXTIspsXaESd9P7WOVtnMpEGyERmcXNvYese409KE9Zwza09rugcliorGeDQvjrr3MppjkVnftXWuVC1JjjPXfqzc8ZfT1DRcgWJ3GieaTP0rd+PN8zqGyAj7OxYG6dJ7ZZp98FLi16P60Y7MDl9lIIto=; c=relaxed/relaxed; s=zohomail; d=collabora.com; v=1; bh=VzZMLJITLVDB0A5Z42maKwswLtuUp4zeciOTqXGQ8aA=; h=Content-Description:Content-ID:Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Sender:Resent-Cc:Resent-Date:Resent-To:Reply-To:Resent-Message-ID:Resent-From:Sender:Subject:To:Date:From:Message-Id:Reply-To:Subject:To:Cc; Received: by smtp.zohomail.com with SMTPS id 179381879157175.33447173328659; Wed, 4 Nov 2026 10:59:51 -0800 (PST) Message-ID: <86b801ce-a56c-4ff8-8915-9be369fc0ce8@collabora.com> Date: Wed, 4 Nov 2026 19:59:43 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] media: qcom: iris: describe QC10C as TP10 To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Mauro Carvalho Chehab , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Bryan O'Donoghue , Stanimir Varbanov Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , linux-media@vger.kernel.org, Nicolas Dufresne , Vikash Garodia , Dikshita Agarwal , Neil Armstrong References: <20261104-ubwc-format-docs-v1-0-389044012b4e@oss.qualcomm.com> <20261104-ubwc-format-docs-v1-7-389044012b4e@oss.qualcomm.com> Content-Language: en-US, de-DE, en-GB From: Robert Mader In-Reply-To: <20261104-ubwc-format-docs-v1-7-389044012b4e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Nice, very happy to see the series! On 04.11.26 17:36, Dmitry Baryshkov wrote: > The comment describing the QC10C buffer layout calls it a compressed > P010. It is not: If I'm not mistaken the display engine / the DRM side (including Mesa) describes it as P010+QCOM_COMPRESSED as well, and so does my pending Gstreamer MR [1] . So if we can't pretend that QC10C == P010+QCOM_COMPRESSED, then we probably need a DRM_FORMAT_TP10, wire that up everywhere etc. OTOH if we want to keep the DRM side as is, then the comment should reflect that, IMO. Best regards, Robert 1: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8195 > P010 stores each sample in 16 bits, QC10C packs three > 10-bit samples in each 32-bit word, which is what the stride computed > below (width * 4 / 3) assumes. Name the format correctly. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index eb8de60c1177..ec2bf2a2d953 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -266,7 +266,7 @@ static u32 iris_yuv_buffer_size_qc08c(struct iris_inst *inst) > > /* > * QC10C: > - * UBWC-compressed format for P010. > + * UBWC-compressed TP10, YUV 4:2:0 with three 10 bit samples packed in 32 bits. > * Contains 4 planes in the following order - > * (A) Y_Meta_Plane > * (B) Y_UBWC_Plane >