mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wan wei <onewayforever@gmail.com>
To: borislav.petkov@amd.com, dougthompson@xmission.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] check-dbam1-if-there-is-only-one-DIMM-on-dbam0 in unganged  mode
Date: Thu, 6 Aug 2009 18:44:34 +0800	[thread overview]
Message-ID: <86bb1aef0908060344h37f304c1jf1138b4cb865cbe2@mail.gmail.com> (raw)

    When I populated just one DIMM for each of the two channels  of
the cpu node in unganged mode,   there was only one channel found by
edac.
    In counting the channels, if there is only one DIMM found by
dbam0,  i think dbam1 should be checked for the other one  also.
    Below is the patch

Signed-off-by: Wan Wei<wanwei@dawning.com.cn>

---
 drivers/edac/amd64_edac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index e2a10bc..afd210a 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -1248,7 +1248,7 @@ static int f10_early_channel_count(struct amd64_pvt *pvt)
        /* If more than 2 DIMMs are present, then we have 2 channels */
        if (channels > 2)
                channels = 2;
-       else if (channels == 0) {
+       else if (channels <= 1) {
                /* No DIMMs on DCT0, so look at DCT1 */
                err = pci_read_config_dword(pvt->dram_f2_ctl, DBAM1, &dbam);
                if (err)
-- 
1.4.4.2

             reply	other threads:[~2009-08-06 10:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 10:44 wan wei [this message]
2009-08-06 14:42 ` Borislav Petkov
2009-08-06 14:58   ` wan wei
2009-08-06 15:18     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bb1aef0908060344h37f304c1jf1138b4cb865cbe2@mail.gmail.com \
    --to=onewayforever@gmail.com \
    --cc=borislav.petkov@amd.com \
    --cc=dougthompson@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®