From: "Kumar, Udit" <u-kumar1@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Yemike Abhilash Chandra <y-abhilashchandra@ti.com>, <nm@ti.com>,
<vigneshr@ti.com>
Cc: <kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <vaishnav.a@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <imx@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <u-kumar1@ti.com>
Subject: Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
Date: Mon, 21 Jul 2025 19:42:57 +0530 [thread overview]
Message-ID: <86bbb4c1-18a9-4917-8554-97d540b72b5a@ti.com> (raw)
In-Reply-To: <92627ace-1fc8-45a7-a25e-76f410427f0c@kernel.org>
On 7/21/2025 7:39 PM, Krzysztof Kozlowski wrote:
> On 21/07/2025 16:07, Kumar, Udit wrote:
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>> cdns_csi2rx0: csi-bridge@4504000 {
>>> compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>> reg = <0x00 0x04504000 0x00 0x1000>;
>>> + interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>> Just cosmetic thing, if you are doing v2 then consider 152 first ,
>> followed by 153.
>
> No, you cannot just randomly change numbers or the order.
>
To be precise both , interrupt-names and interrupts,
if this make sense to change.
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-07-21 14:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
2025-07-14 9:27 ` [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
2025-07-21 14:07 ` Kumar, Udit
2025-07-21 14:09 ` Krzysztof Kozlowski
2025-07-21 14:12 ` Kumar, Udit [this message]
2025-07-21 14:22 ` Krzysztof Kozlowski
2025-07-21 14:10 ` Kumar, Udit
2025-07-22 5:50 ` Yemike Abhilash Chandra
2025-07-25 10:46 ` Kumar, Udit
2025-07-30 19:35 ` Jared McArthur
2025-07-14 9:27 ` [PATCH 2/7] arm64: dts: ti: k3-j721e-main: " Yemike Abhilash Chandra
2025-07-14 9:27 ` [PATCH 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: " Yemike Abhilash Chandra
2025-07-14 9:27 ` [PATCH 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: " Yemike Abhilash Chandra
2025-07-14 9:27 ` [PATCH 5/7] arm64: dts: ti: k3-j722s-main: " Yemike Abhilash Chandra
2025-07-14 9:27 ` [PATCH 6/7] arm64: dts: ti: k3-am62-main: " Yemike Abhilash Chandra
2025-07-14 9:27 ` [PATCH 7/7] arm64: dts: ti: k3-am62a-main: " Yemike Abhilash Chandra
2025-07-14 15:24 ` [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Rob Herring (Arm)
2025-07-17 20:45 ` Jared McArthur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bbb4c1-18a9-4917-8554-97d540b72b5a@ti.com \
--to=u-kumar1@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®