From: Can Guo <quic_cang@quicinc.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: bvanassche@acm.org, adrian.hunter@intel.com, beanhuo@micron.com,
avri.altman@wdc.com, junwoo80.lee@samsung.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Stanley Chu" <stanley.chu@mediatek.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Andrew Halaney" <ahalaney@redhat.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Brian Masney" <bmasney@redhat.com>,
"moderated list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER
DRIVER..." <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v5 01/10] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params
Date: Tue, 28 Nov 2023 15:49:36 +0800 [thread overview]
Message-ID: <86c27d90-9280-489e-b00e-187977657ee4@quicinc.com> (raw)
In-Reply-To: <20231128053136.GE3088@thinkpad>
On 11/28/2023 1:31 PM, Manivannan Sadhasivam wrote:
> On Tue, Nov 28, 2023 at 10:49:36AM +0530, Manivannan Sadhasivam wrote:
>> On Thu, Nov 23, 2023 at 12:46:21AM -0800, Can Guo wrote:
>>> Structure ufs_dev_params is actually used in UFS host vendor drivers to
>>> declare host specific power mode parameters, like ufs_<vendor>_params or
>>> host_cap, which makes the code not very straightforward to read. Rename the
>>> structure ufs_dev_params to ufs_host_params and unify the declarations in
>>> all vendor drivers to host_params.
>>>
>>> In addition, rename the two functions ufshcd_init_pwr_dev_param() and
>>> ufshcd_get_pwr_dev_param() which work based on the ufs_host_params to
>>> ufshcd_init_host_param() and ufshcd_negotiate_pwr_param() respectively to
>>> avoid confusions.
>>>
>>> This change does not change any functionalities or logic.
>>>
>>> Acked-by: Andrew Halaney <ahalaney@redhat.com>
>>> Signed-off-by: Can Guo <quic_cang@quicinc.com>
>>
>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>
>> - Mani
>>
>>> ---
>>> drivers/ufs/host/ufs-exynos.c | 7 ++--
>>> drivers/ufs/host/ufs-hisi.c | 11 +++----
>>> drivers/ufs/host/ufs-mediatek.c | 12 +++----
>>> drivers/ufs/host/ufs-qcom.c | 12 +++----
>>> drivers/ufs/host/ufshcd-pltfrm.c | 69 ++++++++++++++++++++--------------------
>>> drivers/ufs/host/ufshcd-pltfrm.h | 10 +++---
>>> 6 files changed, 57 insertions(+), 64 deletions(-)
>>>
>
> [...]
>
>>> diff --git a/drivers/ufs/host/ufshcd-pltfrm.h b/drivers/ufs/host/ufshcd-pltfrm.h
>>> index a86a3ad..2d4d047 100644
>>> --- a/drivers/ufs/host/ufshcd-pltfrm.h
>>> +++ b/drivers/ufs/host/ufshcd-pltfrm.h
>>> @@ -10,7 +10,7 @@
>>> #define UFS_PWM_MODE 1
>>> #define UFS_HS_MODE 2
>>>
>>> -struct ufs_dev_params {
>>> +struct ufs_host_params {
>>> u32 pwm_rx_gear; /* pwm rx gear to work in */
>>> u32 pwm_tx_gear; /* pwm tx gear to work in */
>>> u32 hs_rx_gear; /* hs rx gear to work in */
>>> @@ -25,10 +25,10 @@ struct ufs_dev_params {
>>> u32 desired_working_mode;
>>> };
>>>
>>> -int ufshcd_get_pwr_dev_param(const struct ufs_dev_params *dev_param,
>>> - const struct ufs_pa_layer_attr *dev_max,
>>> - struct ufs_pa_layer_attr *agreed_pwr);
>>> -void ufshcd_init_pwr_dev_param(struct ufs_dev_params *dev_param);
>>> +int ufshcd_negotiate_pwr_param(const struct ufs_host_params *host_param,
>>> + const struct ufs_pa_layer_attr *dev_max,
>>> + struct ufs_pa_layer_attr *agreed_pwr);
>>> +void ufshcd_init_host_param(struct ufs_host_params *host_param);
>
> Noticed this after giving my R-b tag. Could you please rename the functions to:
>
> int ufshcd_negotiate_pwr_params(const struct ufs_host_params *host_params,...
> void ufshcd_init_host_params(struct ufs_host_params *host_params);
>
> Not a big deal, but since the argument passed to both functions are 'params',
> it'd be good if the function definition also use the same plural form.
>
No worries, will do in next version.
Thanks,
Can Guo.
> - Mani
>
next prev parent reply other threads:[~2023-11-28 7:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 8:46 [PATCH v5 00/10] Enable HS-G5 support on SM8550 Can Guo
2023-11-23 8:46 ` [PATCH v5 01/10] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params Can Guo
2023-11-28 5:19 ` Manivannan Sadhasivam
2023-11-28 5:31 ` Manivannan Sadhasivam
2023-11-28 7:49 ` Can Guo [this message]
2023-11-28 5:31 ` Nitin Rawat
2023-11-23 8:46 ` [PATCH v5 02/10] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param() Can Guo
2023-11-28 5:10 ` Nitin Rawat
2023-11-28 5:22 ` Manivannan Sadhasivam
2023-11-23 8:46 ` [PATCH v5 03/10] scsi: ufs: ufs-qcom: Setup host power mode during init Can Guo
2023-11-28 5:06 ` Nitin Rawat
2023-11-28 5:24 ` Manivannan Sadhasivam
2023-11-23 8:46 ` [PATCH v5 04/10] scsi: ufs: ufs-qcom: Limit negotiated gear to selected PHY gear Can Guo
2023-11-28 5:45 ` Manivannan Sadhasivam
2023-11-28 8:05 ` Can Guo
2023-11-28 10:52 ` Manivannan Sadhasivam
2023-11-28 11:03 ` Can Guo
2023-11-28 11:20 ` Manivannan Sadhasivam
2023-11-23 8:46 ` [PATCH v5 05/10] scsi: ufs: ufs-qcom: Allow the first init start with the maximum supported gear Can Guo
2023-11-23 8:46 ` [PATCH v5 06/10] scsi: ufs: ufs-qcom: Limit HS-G5 Rate-A to hosts with HW version 5 Can Guo
2023-11-28 5:15 ` Nitin Rawat
2023-11-28 5:55 ` Manivannan Sadhasivam
2023-11-28 7:48 ` Can Guo
2023-11-28 10:55 ` Manivannan Sadhasivam
2023-11-28 10:59 ` Can Guo
2023-11-28 11:24 ` Manivannan Sadhasivam
2023-11-23 8:46 ` [PATCH v5 07/10] scsi: ufs: ufs-qcom: Set initial PHY gear to max HS gear for HW ver 5 and newer Can Guo
2023-11-28 6:00 ` Manivannan Sadhasivam
2023-11-28 7:58 ` Can Guo
2023-11-28 10:59 ` Manivannan Sadhasivam
2023-11-28 11:01 ` Can Guo
2023-11-28 11:22 ` Manivannan Sadhasivam
2023-11-23 8:46 ` [PATCH v5 08/10] phy: qualcomm: phy-qcom-qmp-ufs: Rectify SM8550 UFS HS-G4 PHY Settings Can Guo
2023-11-27 11:07 ` Vinod Koul
2023-11-28 1:50 ` Can Guo
2023-11-28 6:02 ` Manivannan Sadhasivam
2023-11-23 8:46 ` [PATCH v5 09/10] phy: qualcomm: phy-qcom-qmp-ufs: Add High Speed Gear 5 support for SM8550 Can Guo
2023-11-23 12:35 ` Dmitry Baryshkov
2023-11-24 1:55 ` Can Guo
2023-11-28 6:47 ` Manivannan Sadhasivam
2023-11-28 9:00 ` Can Guo
2023-11-28 9:59 ` neil.armstrong
2023-11-28 10:03 ` Can Guo
2023-11-23 8:46 ` [PATCH v5 10/10] scsi: ufs: ufs-qcom: Add support for UFS device version detection Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86c27d90-9280-489e-b00e-187977657ee4@quicinc.com \
--to=quic_cang@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bmasney@redhat.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=stanley.chu@mediatek.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®