From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932810AbcHJCOm (ORCPT ); Tue, 9 Aug 2016 22:14:42 -0400 Received: from exvmail.skhynix.com ([166.125.252.79]:42447 "EHLO invmail.skhynix.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932595AbcHJCOl (ORCPT ); Tue, 9 Aug 2016 22:14:41 -0400 X-AuditID: a67dfc4e-f797e6d000000a40-73-57aa8e0d86e2 From: "kwangwoo.lee@sk.com" To: Robin Murphy , Russell King - ARM Linux , Catalin Marinas , "Will Deacon" , Mark Rutland , "linux-arm-kernel@lists.infradead.org" CC: "woosuk.chung@sk.com" , "hyunchul3.kim@sk.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3] arm64: mm: convert __dma_* routines to use start, size Thread-Topic: [PATCH v3] arm64: mm: convert __dma_* routines to use start, size Thread-Index: AQHR7FgIU14uSIRg4kyLePO3ZGSzz6A/+ROAgAGGhkA= Date: Wed, 10 Aug 2016 02:14:30 +0000 Message-ID: <86c4d03a1bf84da6a460fa2cc1455032@nmail01.hynixad.com> References: <1470099050-25407-1-git-send-email-kwangwoo.lee@sk.com> <80a4602f-8105-fe2e-0f52-ee23f2c0b2e4@arm.com> In-Reply-To: <80a4602f-8105-fe2e-0f52-ee23f2c0b2e4@arm.com> Accept-Language: ko-KR, en-US Content-Language: ko-KR X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.92.132.196] Content-Type: text/plain; charset="ks_c_5601-1987" MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEIsWRmVeSWpSXmKPExsXCNUdUWZe3b1W4QVOznsX7ZT2MFpseX2O1 uLxrDpvFoal7GS2WXr/IZHHwwxNWi5cfT7A4sHusmbeG0ePytYvMHpuX1Ht83iQXwBLFZZOS mpNZllqkb5fAlTG5qY+54JNwxaPfV1gbGDcIdzFyckgImEjcvPCNHcIWk7hwbz1bFyMXh5DA GkaJ7pd3mSCcxYwSaxbvZQWpYhMwlNh7ax+YLSKwmEli/zIZkCJmgYWMEoeOvwbq4OAQFgiQ aN9jDlETKNH15jcbhG0lsbZ5AxOIzSKgKvFt/XE2kHJeASeJ5rksIGEhgRKJ7oVzwA7iFLCW 6D/3lh2khFFAVuLqNRmQMLOAuMTir9eYIW4WkFiy5zyULSrx8vE/VghbUeLb6+/sEPVGEktW z2eCsBUlpnQ/BIvzCghKnJz5hAWiXlLi4IobLBMYxWchWTELSfssJO2zkLQvYGRZxSicmVeW m5iZo1ecnVGZl1mhl5yfu4kRGJPLav/47WB88UvrEKMAB6MSDy8H66pwIdbEsuLK3EOMEhzM SiK8p3uAQrwpiZVVqUX58UWlOanFhxilOViUxHm//e8LFxJITyxJzU5NLUgtgskycXBKNTD2 tq141Riuv3ndq1Wr07n3XdBOsGr0mWGo3xBwdHLS4/ZvaqZuZ0S3epWazjO+2n3lGWuJcW52 HK96+c/gRG2OGVO/Kx64Kbudg7nPQfDy2num24zVw+rSz05fXnv4fFmv47LtOw5csC7fPlWN UfOP0IH7c5vr5j3fvFuGwyDAe0HDUrYPrHOVWIozEg21mIuKEwGW9fmvxQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7A2Ek84032174 Hi Robin, > -----Original Message----- > From: Robin Murphy [mailto:robin.murphy@arm.com] > Sent: Tuesday, August 09, 2016 8:51 PM > To: À̱¤¿ì(LEE KWANGWOO) MS SW; Russell King - ARM Linux; Catalin Marinas; Will Deacon; Mark Rutland; > linux-arm-kernel@lists.infradead.org > Cc: Á¤¿ì¼®(CHUNG WOO SUK) MS SW; ±èÇöö(KIM HYUNCHUL) MS SW; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3] arm64: mm: convert __dma_* routines to use start, size > > On 02/08/16 01:50, Kwangwoo Lee wrote: > > __dma_* routines have been converted to use start and size instread of > > start and end addresses. The patch was origianlly for adding > > __clean_dcache_area_poc() which will be used in pmem driver to clean > > dcache to the PoC(Point of Coherency) in arch_wb_cache_pmem(). > > > > The functionality of __clean_dcache_area_poc() was equivalent to > > __dma_clean_range(). The difference was __dma_clean_range() uses the end > > address, but __clean_dcache_area_poc() uses the size to clean. > > > > Thus, __clean_dcache_area_poc() has been revised with a fallthrough > > function of __dma_clean_range() after the change that __dma_* routines > > use start and size instead of using start and end. > > > > As a consequence of using start and size, the name of __dma_* routines > > has also been altered following the terminology below: > > area: takes a start and size > > range: takes a start and end > > This looks pretty nice and tidy now; I don't see anything obviously > wrong, and comparing before-and-after disassemblies shows essentially > nothing more than the movement of some add instructions as expected, so: > > Reviewed-by: Robin Murphy Thank you very much for your review! I'm going to add Reviewed-by: and Cc: lines and send it again. Thanks! Best Regards, Kwangwoo Lee