From: Dave Hansen <dave.hansen@intel.com>
To: "Jörn Heusipp" <osmanx@heusipp.de>,
linux-kernel@vger.kernel.org,
"Dave Hansen" <dave.hansen@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
stable@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Adam Dunlap <acdunlap@google.com>
Subject: Re: [tip: x86/urgent] x86/cpu: Provide default cache line size if not enumerated
Date: Thu, 30 May 2024 08:33:18 -0700 [thread overview]
Message-ID: <86c8a026-4df7-4ba8-b0e5-6289ae584289@intel.com> (raw)
In-Reply-To: <f12ab64f-fd59-491e-a44a-6ae570a81ada@heusipp.de>
On 5/30/24 08:05, Jörn Heusipp wrote:
>>
>> + /* Provide a sane default if not enumerated: */
>> + if (!c->x86_clflush_size)
>> + c->x86_clflush_size = 32;
>> } else {
>> cpuid(0x80000008, &eax, &ebx, &ecx, &edx);
>>
>
> That honestly looks like a mis-merge to me. This is not what I did test.
> x86_clflush_size needs to get set in the top-level else branch in which
> it is not already set. commit 95bfb35269b2e85cff0dd2c957b2d42ebf95ae5f
> had switched the if branches around.
You're totally right. Thank you for catching that.
I think a variable removal flipped that code around and it confused me
when I did the rebase. It should be fixed up now.
Again, thanks a bunch for the report, the testing, and catching my
screwup quickly!
next prev parent reply other threads:[~2024-05-30 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 14:23 tip-bot2 for Dave Hansen
2024-05-30 15:05 ` Jörn Heusipp
2024-05-30 15:33 ` Dave Hansen [this message]
2024-05-30 15:38 tip-bot2 for Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86c8a026-4df7-4ba8-b0e5-6289ae584289@intel.com \
--to=dave.hansen@intel.com \
--cc=acdunlap@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=osmanx@heusipp.de \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®