From: Mario Limonciello <superm1@kernel.org>
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, syed.sabakareem@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..."
<linux-sound@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ASoC: amd: acp: Adjust pdm gain value
Date: Thu, 21 Aug 2025 08:06:08 -0500 [thread overview]
Message-ID: <86ca694c-a034-4291-a2ce-303895522156@kernel.org> (raw)
In-Reply-To: <20250821054606.1279178-1-venkataprasad.potturu@amd.com>
On 8/21/2025 12:45 AM, Venkata Prasad Potturu wrote:
> Set pdm gain value by setting PDM_MISC_CTRL_MASK value.
> To avoid low pdm gain value.
>
> Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
> ---
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>
> Changes since v1:
> - remove pdm gain adjustment using module parameter.
>
> sound/soc/amd/acp/amd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h
> index cb8d97122f95..73a028e67246 100644
> --- a/sound/soc/amd/acp/amd.h
> +++ b/sound/soc/amd/acp/amd.h
> @@ -130,7 +130,7 @@
> #define PDM_DMA_INTR_MASK 0x10000
> #define PDM_DEC_64 0x2
> #define PDM_CLK_FREQ_MASK 0x07
> -#define PDM_MISC_CTRL_MASK 0x10
> +#define PDM_MISC_CTRL_MASK 0x18
> #define PDM_ENABLE 0x01
> #define PDM_DISABLE 0x00
> #define DMA_EN_MASK 0x02
next prev parent reply other threads:[~2025-08-21 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 5:45 Venkata Prasad Potturu
2025-08-21 13:06 ` Mario Limonciello [this message]
2025-09-02 11:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ca694c-a034-4291-a2ce-303895522156@kernel.org \
--to=superm1@kernel.org \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=syed.sabakareem@amd.com \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®