mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Oliver Upton <oupton@kernel.org>,
	kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Steffen Eiden <seiden@linux.ibm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jing Zhang <jingzhangos@google.com>,
	Karl Mehltretter <kmehltretter@gmail.com>,
	Fuad Tabba <tabba@google.com>,
	kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 00/10] KVM: arm64: Nested stage-2 walk error handling and other small fixes
Date: Mon, 28 Sep 2026 16:58:34 +0100	[thread overview]
Message-ID: <86cxtx4bbp.wl-maz@kernel.org> (raw)
In-Reply-To: <20260928152507.2116110-1-fuad.tabba@linux.dev>

On Mon, 28 Sep 2026 16:24:57 +0100,
Fuad Tabba <fuad.tabba@linux.dev> wrote:
> 
> Hi folks,
> 
> Small KVM/arm64 fixes that came out of reviewing Karl's SMCCC filter
> series [1], and it just kept growing.
> 
> The first two are WARNs that userspace or a guest can trigger: the
> SMCCC filter one on an allocation failure userspace can force with a
> memory cgroup limit, which Sashiko raised [2], the nested one when an
> L1 guest programs an invalid VTCR_EL2. Patches 3 and 4 are the same
> walk's return values. With an invalid VTCR_EL2 or a stage-2 descriptor
> KVM can't read, AT S12E{0,1}{R,W} was retried forever instead of
> retiring with the fault in PAR_EL1. Reporting the unreadable descriptor
> as a Data Abort instead, for the stage-1 walks too, is a separate
> change I'll send later.

Why later?

> Patch 5 extends the AT selftest to cover the
> SL0 case.
> 
> The three documentation patches fix identifiers in api.rst that don't
> exist anywhere in the tree, and the last two fix selftest leaks.

<rant>
What is this series about? Suppressing spurious warnings? Fixing the
PTWs?  Fixing the documentation for something totally unrelated?
Random selftest maintenance?

To give you an idea, here's what my -next branch looks like:

maz@valley-girl:~/hot-poop/arm-platforms$ git log --oneline --merges v7.3-rc3..kvmarm-master/next
5c49bb52faf38 Merge branch kvm-arm64/misc-7.4 into kvmarm-master/next
c345ec7f39efd Merge branch kvm-arm64/pre-faulting into kvmarm-master/next
2716832906bd9 Merge branch kvm-arm64/s2-rmap into kvmarm-master/next
edeb68e3d4e0c Merge tag 'kvmarm-fixes-7.3-1' into kvm-arm64/s2-rmap
ede721366f1bf Merge branch kvm-arm64/gicv5-7.4 into kvmarm-master/next
062cbcbae3e00 Merge branch kvm-arm64/gicv5-7.4 into kvmarm-master/next
928737a70c491 Merge branch kvm-arm64/hyp-type-checking-7.4 into kvmarm-master/next
1f99916b2a3d7 Merge branch kvm-arm64/selftests-7.4 into kvmarm-master/next
a8f9576fa8466 Merge branch kvm-arm64/doc-7.4 into kvmarm-master/next
7413af8a61612 Merge branch kvm-arm64/ffa-7.4 into kvmarm-master/next

Where does this series fit? What is the theme? Do you really expect me
to cherry-pick one patch after the other and build 3 or 4 consistent
series out of this? Or should simply apply it as kvm-arm64/random-stuff-from-fuad-7.4?

My definition of a series is "an ordered set of changes that have a
common theme or form a progression towards a precise goal". This is
not a series, but a patch dump.
</rant>

	M.

-- 
Without deviation from the norm, progress is not possible.

  parent reply	other threads:[~2026-09-28 15:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 15:24 Fuad Tabba
2026-09-28 15:24 ` [PATCH v1 01/10] KVM: arm64: Don't WARN on SMCCC filter reserved range allocation failure Fuad Tabba
2026-09-28 15:54   ` Oliver Upton
2026-09-28 16:14     ` Fuad Tabba
2026-09-28 15:24 ` [PATCH v1 02/10] KVM: arm64: nv: Don't WARN on an invalid VTCR_EL2 Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 03/10] KVM: arm64: nv: Don't loop on AT S12E{0,1}{R,W} with " Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 04/10] KVM: arm64: nv: Return a failed stage-2 descriptor read as a fault Fuad Tabba
2026-09-28 16:47   ` Oliver Upton
2026-09-28 17:46     ` Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 05/10] KVM: arm64: selftests: Test AT S12E1R with an invalid VTCR_EL2.SL0 Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 06/10] Documentation: KVM: Fix the name of the SMCCC filter attribute Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 07/10] Documentation: KVM: Fix the name of KVM_ARM_SET_COUNTER_OFFSET Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 08/10] Documentation: KVM: Fix the name of KVM_ARM_FEATURE_ID_RANGE_IDX Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 09/10] KVM: arm64: selftests: Free the VMs in smccc_filter and psci_test Fuad Tabba
2026-09-28 15:25 ` [PATCH v1 10/10] KVM: arm64: selftests: Free the thread arrays in vgic_lpi_stress Fuad Tabba
2026-09-28 15:58 ` Marc Zyngier [this message]
2026-09-28 16:12   ` [PATCH v1 00/10] KVM: arm64: Nested stage-2 walk error handling and other small fixes Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cxtx4bbp.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=jingzhangos@google.com \
    --cc=joey.gouly@arm.com \
    --cc=kmehltretter@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=oupton@kernel.org \
    --cc=seiden@linux.ibm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®